Php 7.2 compliance workshop php benelux
•
1 gefällt mir•1,006 views
When migrating, we often need to review old code and target only interesting issues. This session will connect the backward incompatibilities and new features to actual location in the code, relying on static analysis to process a large code base quickly. Based on the accumulated experience of the tools, we will review the issues, diagnose criticality, select the best fixes, and prioritize tasks. All tools used will be open source, and you can try them at home for more validation.
Empfohlen
Weitere ähnliche Inhalte
Was ist angesagt?
Was ist angesagt? (20)
Andere mochten auch
Andere mochten auch (20)
Ähnlich wie Php 7.2 compliance workshop php benelux
Ähnlich wie Php 7.2 compliance workshop php benelux (20)
Mehr von Damien Seguy
Mehr von Damien Seguy (20)
Kürzlich hochgeladen
Kürzlich hochgeladen (20)
Php 7.2 compliance workshop php benelux
- 1. PHP 7.2 COMPLIANCE WORKSHOP Damien Seguy @exakat Antwerp, January 2017
- 2. FULL AHEAD TO PHP 7. 2 Changing version is always a big challenge Backward incompatibilities New features Learn, spot, fix, repeat 01
- 3. SPEAKER Damien Seguy CTO at exakat Static code analysis for PHP Retiring house for oldest elephpant
- 4. SYNOPSIS What is in the next version ? Where in my code ? How to replace this ? Get documentation Find issue Fix code
- 5. MIGRATION TO PHP 7.2 Migration to PHP 7.0, 7.1 and 7.2 / 8.0 From PHP 5.6 No framework, no libraries Tools, experience, discipline
- 6. DESTINATION
- 7. LIVING ON THE EDGE http://php.net/manual/en/migration71.php Online UPGRADING TO PHP 7.0 Free Book, PDF Davey Shafik is RM for PHP 7.1 Lots of blogs and articles
- 8. LIVING ON THE BLEEDING EDGE https://github.com/php/php-src/blob/master/ UPGRADING https://github.com/php/php-src/blob/master/ NEWS https://wiki.php.net/rfc http://bugs.php.net/
- 14. WHICH TO BELIEVE Books PHP manual Migration, blogs Wiki (Implemented) NEWS Bugs Wiki (Future) Yearly Monthly Weekly As possible As needed
- 15. PHP has 3 phases syntax definitions execution WHERE DOES CODE BREAK? Checked with phplint Checked with tests Checked code review
- 16. <?php function splitNames($fullname, $fullname) { list($first, $last) = split($fullname, ' '); } ?> WHERE WILL CODE BREAK? SyntaxDefinitionsExecution
- 17. TOOLS FOR MIGRATION • Your own experience with your code • Lint • Search • Static analysis • Logs
- 18. LINTING PHP 7
- 19. PHP LINTING • command line : php -l filename.php • Spot parse errors • Works on files only : • For directories, see composer phplint/phplint
- 20. PHP LINTING Error messages in PHP 0 550 1100 1650 2200 5.0 5.1 5.2 5.3 5.4 5.5 5.6 7.0 7.1 7.2 Total Distinct
- 21. Backward unlintable code 0 1 2 3 4 5.2 5.3 5.4 5.5 5.6 7.0 7.1 7.2
- 22. Code focused on current versions 0 1.25 2.5 3.75 5 5.2 5.3 5.4 5.5 5.6 7.0 7.1 7.2
- 23. Backward unlintable code 0 0.25 0.5 0.75 1 5.2 5.3 5.4 5.5 5.6 7.0 7.1 7.2
- 24. 0 1.25 2.5 3.75 5 5.2 5.3 5.4 5.5 5.6 7.0 7.1 7.2 0 1 2 3 4 5.2 5.3 5.4 5.5 5.6 7.0 7.1 7.2 0 0.75 1.5 2.25 3 5.2 5.3 5.4 5.5 5.6 7.0 7.1 7.2 0 1.75 3.5 5.25 7 5.2 5.3 5.4 5.5 5.6 7.0 7.1 7.2 0 0.25 0.5 0.75 1 5.2 5.3 5.4 5.5 5.6 7.0 7.1 7.2
- 25. PHP -L WITH OTHER VERSIONS syntax error, unexpected 'new' (T_NEW) Assigning the return value of new by reference is deprecated (PHP 5.6) PHP 7 -> PHP 5.6 $o =& new Stdclass();
- 26. REDEFINITION OF PARAMETER <?php function foo($a, $a, $a) { print $a."n"; } foo('x', 'y', 'z'); ?>
- 27. SWITCH STATEMENTS MAY ONLY CONTAIN ONE DEFAULT CLAUSE <?php switch($x) { case '1' : break; default : break; default : break; case '2' : break; }
- 28. SWITCH STATEMENTS MAY ONLY CONTAIN ONE DEFAULT CLAUSE switch($x) { case 1 : break; case 0+1 : break; case '1' : break; case true : break; case 1.0 : break; case $y : break; }
- 29. DEPRECATED FEATURES Not happening if a parent case has a __constructor() Not happening if the class is in a namespace Use the E_DEPRECATED error level while in DEV Methods with the same name as their class will not be constructors in a future version of PHP; foo has a deprecated constructor
- 30. MIGRATION TO PHP 7.1 Lint with PHP 7.1 PHP 7.2 (or src) PHP 5.6 (current), PHP 7.0 PHP 5.5, 5.4,… (manual)
- 31. PHP 7 LINTING Pre-commit Use different versions Be ruthless with unlintable files
- 32. PHP has 3 phases syntax definitions execution WHERE DOES CODE BREAK? Checked with phplint Checked with tests Checked code review
- 33. STATIC ANALYSIS
- 34. DEFINITION Review code without executing it Audit code by reading it Common in C/C++, Java, Javascript Hot subject to PHP
- 35. GREP/SEARCH Any searching facility Pro : High speed, great for keyword search, universal Cons : Little repeat value, no PHP semantics
- 36. GREP ON PHP CODE 1318 reports doc/_ext/configext.py: parts = text.split("']['") js/codemirror/lib/codemirror.js: var change = {from: pos, to: po po/zh_CN.po:"example: address can be split into stree libraries/Advisor.php: public static function splitJus libraries/plugins/ImportCsv.php: $tmp = preg_split('/,( ?)/', $c libraries/Config.php: // split file to lines
- 37. STATIC ANALYSIS PHP 5 / 7 Calisthenics ClearPHP Performance
- 38. STATIC ANALYSIS TOOLS PHP7mar PHP7cc Phan Exakat PHP inspections
- 39. PHP7MAR PHP 7 Migration Assistant Report (MAR) Alexia : https://github.com/Alexia/php7mar Works with regex Produces a .md file
- 40. 12 results
- 41. PHP7CC PHP 7 Compatibility Checker Authored by sstalle https://github.com/sstalle/php7cc PHP 5, works with "nikic/php-parser": "~1.4" Display to stdout
- 42. 8.506s 3 results 27 analysis php ~/.composer/vendor/bin/php7cc library/ File: /Users/famille/Desktop/analyze/library/Analyzer/Analyzer.php > Line 231: Function argument(s) returned by "func_get_args" might have been modified func_get_args(); File: /Users/famille/Desktop/analyze/library/Analyzer/Functions/MarkCallable.php > Line 32: Nested by-reference foreach loop, make sure there is no iteration over the same array foreach ($lists as $id => &$function) { } File: /Users/famille/Desktop/analyze/library/Tasks/Analyze.php > Line 118: Possible adding to array on the last iteration of a by-reference foreach loop $dependencies[$v] = $dep; Checked 873 files in 8.506 seconds
- 43. PHAN Static analysis for PHP Inited by Rasmus, under work at Etsy https://github.com/etsy/phan PHP 7 only, with ext/ast php ~/.composer/vendor/bin/phan -f phan.in -3 vendor -o phan.out
- 45. 11.244s 333 results PhanUndeclaredProperty Reference to undeclared property processed PhanUndeclaredProperty Reference to undeclared property stdclass->results PhanNonClassMethodCall Call to method relateTo on non-class type null PhanStaticCallToNonStatic Static call to non-static method loadercypher::saveTokenCounts() defined at library//L PhanAccessPropertyProtected Cannot access protected property tokenizertoken::$alternativeEnding PhanTypeMismatchArgument Argument 1 (atom) is string but analyzerstructuresuseconstant::atomfunctionis() t PhanUndeclaredClassMethod Call to method __construct from undeclared class reportsxmlwriter PhanUndeclaredVariable Variable $r is undeclared 84 analysis
- 46. EXAKAT Static analysis engine for PHP https://github.com/exakat/exakat PHP 5.2 to 7.2; php exakat.phar project -p name
- 47. 20 mins6798 results290 analysis
- 48. 20 mins6798 results290 analysis
- 49. PHP INSPECTIONS Static analysis engine for within the IDE Vladimir Reznichenko https://bitbucket.org/kalessil/phpinspectionsea Written in Java Runs from within PHPstorm
- 51. WRITE YOUR OWN? https://github.com/exakat/php-static-analysis-tools.git PHP 7 : use ext/ast PHP 5 :"nikic/php-parser" Better Reflexion Avoid regex (but it does work)
- 52. PHP 7.1 : WHAT CHANGES? Incompatible changes New features Features/Incompatibilities from PHP 5.6 => 7.2
- 53. HOW TO SPOT ISSUES? Code knowledge lint Grep / Search Static analysis Logs / error_reporting Unit Tests
- 56. REMOVED FEATURES
- 59. REMOVED FUNCTIONS call_user_method() call_user_method_array() Repleacable by $funcname Replaced by call_user_func() and call_user_func_array() Partially replaced by variadic png2wbmp() and jpeg2wbmp() Deprecated
- 60. REMOVED VARIABLES $HTTP_RAW_POST_DATA Replace it by php://input php://input is now reusable Since PHP 5.5
- 61. REMOVED INI sql.safe_mode (PHP 7.2) mbstring.internal_encoding mbstring.http_output mbstring.http_input iconv.internal_encoding iconv.input_encoding iconv.output_encoding default_charset }
- 62. DEFAULT_CHARSET htmlentities() PHP 5.3 : ISO-8859-1 PHP 5.4 : UTF-8 PHP 5.6 : default_charset (also UTF 8)
- 63. WHERE TO LOOK FOR ? default_charset Search for ini_set(), ini_get(), ini_get_all(), ini_restore(), get_cfg_var() Search in php.ini, .htaccess Search for htmlentities(), html_entity_decode() and htmlspecialchars()
- 64. PREG_REPLACE AND /E preg_replace(‘/ /e’, ‘evaled code’, $haystack) replaced by preg_replace_callback_array() preg_replace(‘/ /e’, ‘evaled code’, $haystack) preg_replace_callback_array([‘/ /’ => $closure], $haystack) preg_replace_callback(‘/ /’, $closure], $haystack)
- 67. Can't call dynamically! • $func() • call_user_func() • array_map() • or similar assert() with a string argument extract() compact() get_defined_vars() func_get_args() func_get_arg() func_num_args() parse_str() with one argument mb_parse_str() with one argument
- 68. ADDED FEATURES
- 69. ADDED DEFINITIONS Functions Classes Constants 5.3 40 2 80 5.4 0 9 78 5.5 12 11 57 5.6 1 10 10 7.0 10 10 41 7.1 9 3 30 7.2 4 0 15 Total 766 92 1163
- 70. NAME IMPACT get_resources(), intdiv(), is_iterable(), mb_scrub() PREG_JIT_STACKLIMIT_ERROR class Date (from PHP 5.1) Error (new class in PHP 7)
- 72. COLLATERALS
- 73. INVALID OCTALS ARE INVALID Upgraded from silent to Fatal error PHP Parse error: Invalid numeric literal in test.php <?php $x = 0890;
- 74. MORE INVALID OCTALS IN STRINGS <?php var_dump("000" === "400"); PHP 7.1 https://wiki.php.net/rfc/octal.overload-checking
- 75. Invalid numeric are signaled PHP 7.1 Notice: A non well formed numeric value encountered in <?php echo "1 monkey" + "2 bananas";
- 76. MORE RESERVED KEYWORDS bool, int, float, string, null, true, false are no more available for class / interface / traits names mixed, numeric, object, resource are reserved for future use void is reserved in 7.1
- 77. MORE RELAXED KEYWORDS Almost all PHP keywords are now authorized inside classes Methods and constants Except for class, which can't be a class constant name. <?php class foo { const instanceof = 1; function use() { $this->while(4) + foo::instanceof; } }
- 78. STRINGS MAY BE INVALID Upgraded to Fatal error <?php echo "u{1F418}n"; > php56 test.php u{1F418} > php70 test.php 🐘 <?php echo "u{65B0}u{52A0}u{5761}n"; //
- 79. STRINGS MAY BE INVALID Upgraded to Fatal error <?php echo "u{Yes}n"; PHP Parse error: Invalid UTF-8 codepoint escape sequence in test.php on line 3 u{
- 80. HEXADECIMAL NUMERIC STRINGS Also, -0 !! <?php var_dump(1 + 0xf); var_dump(1 + "0xf"); $ php56 test.php int(16) int(16) $ php70 test.php int(16) int(1)
- 81. WARNING FOR STRINGS (7.1) <?php print "2" + "4"; print "3 elephpants" + "4 dolphins"; print "2" + "d4 d"; 6 7 2 Warning: A non-numeric value encountered
- 83. EXCEPTIONS Exception is not the top exception type anymore It is now the 'throwable' interface Impact on Exception handler Avoid type hinting until moved to PHP 7 Impact on Error handler Impact on catch() clauses
- 86. AND MORE CATCHING EXCEPTIONS <?php try { $random = random_bytes(10); } catch( TypeError $e) { // invalid parameter } catch( Error $e) { // invalid length } catch( Exception $e) { // no source of randomness }
- 87. Even more catching exceptions <?php try { attemptSomething(); } catch (RuntimeException $e) { fixSomething(); } catch (InvalidArgumentException $e) { fixSomething(); } catch (BadFunctioncallException $e) { fixSomethingElse(); }
- 88. Even more catching exceptions <?php try { attemptSomething(); } catch (RuntimeException| InvalidArgumentException| BadFunctioncallException $e) { fixSomething(); }
- 89. Even more catching exceptions <?php //try really harder try { attemptSomething(); } catch (Exception $e) { attemptSomething(); }
- 90. NEGATIVE STRING OFFSET (7.1) <?php $string = "abcde"; print $string[-3]; print "$string[3]"; print "$string[-2]"; c d d
- 91. LIST() WITH KEYS <?php $array = ['a' => 1, 'b' => 5, 'c' => 3]; // Assigns to $a, $b and $c in the same order list($a, $b, $c) = $array; // Assigns to $a, $b and $c from the keys //"a", "b" and "c", respectively list("a" => $a, "c" => $c, "b" => $b) = $array; list("a" => $a, "b" => $b, "c" => $c) = $array; list("c" => $c, "a" => $a, "b" => $b) = $array;
- 92. SHORT SYNTAX FOR LIST() <?php $array = ['a' => 1, 'b' => 5, 'c' => 3]; ["a" => $a, "b" => $b, "c" => $c] = $array; // Works even when nested $array = [['a' => 1, 'b' => 5], ['c' => 3]]; [["a" => $a, "b" => $b], ["c" => $c]] = $array;
- 93. CALL-TIME PASS-BY-REFERENCE References are in the function signature Deprecated warnings until PHP 7 Upgraded to Parse error in PHP 7 <?php $a = 3; function f($b) { $b++; } f(&$a); print $a; ?> PHP Parse error: syntax error, unexpected '&' in …
- 94. INCOMPATIBLE CONTEXT <?php class A { function f() { echo get_class($this); } } A::f(); ?> Notice: Undefined variable: $this inA Deprecated: Non-static methodA::f() should not be called statically Notice: Undefined variable: $this inA
- 95. EASY TO SPOT Strict Standards: Non-static method A::f() should not be called statically in test.php on line 6 Deprecated: Non-static method A::f() should not be called statically in test.php on line 6
- 96. CHANGED BEHAVIOR
- 98. FUNC_GET_ARG() <?php function foo($a, $b, $c) { print_r(func_get_args()); ++$a; print_r(func_get_args()); } foo(1,2,3); Array ( [0] => 1 [1] => 2 [2] => 3 ) Array ( [0] => 2 [1] => 2 [2] => 3 )
- 99. USORT() <?php $array = array( 'foo', 'bar', 'php' ); usort($array, function($a, $b) { return 0; } ); print_r($array); Array ( [0] => php [1] => bar [2] => foo ) Array ( [0] => foo [1] => bar [2] => php ) PHP 5 PHP 7
- 100. AUTOMATICALLY FIXED It is not safe to rely on the system's timezone settings. You are required to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier.
- 101. NEW FEATURES
- 102. NEW FEATURES Breaks backward compatibility sometimes FUD Search for places to apply them like for incompatibilities
- 104. FIXING
- 105. DON'T HIDE IN PARENTHESES <?php function getArray() { return [1, 2, 3]; } function squareArray(array &$a) { foreach ($a as &$v) { $v **= 2; } } // Generates a warning in PHP 7. squareArray((getArray())); ?> Parenthesis in arguments won't mask error anymore
- 106. CONSTANT ARRAYS Lots of properties could be turned to constants <?php class Version { const SUPPORTED = ['1.0', '1.1', '2.0', '2.1']; private $an_array = [1,2,3,4]; public function isSupported($x) { return isset(Version::SUPPORTED[$x]); } }
- 107. MODERNIZATION
- 108. FOREACH UPDATE THE ACTUAL ARRAY <?php $array = [0]; foreach ($array as $k => &$val) { print "$kn"; $array[] = 1; } ?> 0 1 2 3 4 5 6 7 8 9 10 11 0
- 109. ARRAY/OBJECT CASTING <?php $arr = [0 => 1, 1 => 2, 2 => 3]; $obj = (object)$arr; // PHP 7.1 echo $obj->{0}; // PHP 7.2 echo $obj->{"0"};
- 112. CLOSURE BINDING <?php class { private $hello = " "; } $obj = new Hello(); $closure = $obj->makeClosure(); $nihao = new (); $closure2 = $closure->bindTo($nihao); $closure2();
- 113. CLOSURE BINDING <?php $closure = function() { echo $this->hello; }; class { private $hello = " "; } $nihao = new (); $closure->call($nihao);
- 116. PARAMETERS EVOLUTION get_headers() has an extra parameter Passing a custom stream context getenv() doesn't need parameter all the current environment variables will be returned get_class() doesn't allow null anymore
- 117. REALLY NEW
- 119. SPACESHIP OPERATOR Very Cute <=> Replaces a lot of code Mainly useful for usort() <?php // PHP 5.6 if ($a > $b) { echo 1; } elseif ($a < $b) { echo -1; } else { echo 0; } // PHP 7.0 echo $a <=> $b; // 0
- 121. GENERATORS RETURNS <?php function factors($limit) { return 'first'; yield 2; return 'second'; yield 3; return 'third'; yield 5; } $gen = factors(sqrt($prime)); foreach ($gen as $n) { echo "$nn"; if ($n == 3) {break 1;} } print $gen->getReturn(); // second Generators returns The last return is accessible The generator returns the final state
- 122. SCALAR TYPEHINT Whenever type is tested => <?php function foo($x) { if (!is_string($x)) { throw new Exception('Type error while calling ' . __FUNCTION__); } ... } <?php function foo(string $x) { ... }
- 123. SCALAR TYPEHINT BACK IN 5.6 <?php function foo(string $x) { } foo('that'); Catchable fatal error: Argument 1 passed to foo() must be an instance of string, string given, called in file..
- 124. VARIOUS SCALAR TYPEHINT <?php function foo(?int $a, float $b, float $c) : ?int { return $a + $b + $c; } echo foo(null, 2, 1); // 4 echo foo(1.2, 2, 1); // 4 echo foo(1, 2.2, 1); // 4 echo foo(1, 2.7, 1.4); // 5
- 125. OPTION FOR STRICT TYPING <?php // Enable strict types declare(strict_types=1); declare(encoding='ISO-8859-1'); declare(ticks=1); namespace FooBar; foo('that');
- 127. Minimum args in custom functions is Fatal error scalar, array, callable, class or interfaces void (PHP 7.1) <?php function foo(?int $a, float $b, float $c) { return $a + $b + $c; } echo foo(2, 1); Minimum args number Fatal error: Uncaught Error: Too few arguments to function foo(), 2 passed in
- 128. HELPING AT MIGRATION Document the evolutions between two versions Identify anchors in the code Link the migration to the actual code Keywords, syntax, code structures Suggest fallback, work-around, detection tools
- 129. HELPING AT MIGRATION Backward incompatibilities Removed / renamed features Collaterals Changed behaviors
- 130. HELPING AT MIGRATION New features Fixing Totally new Spot previous work-arounds
- 133. SUMMARY Check the manuals PHP lint is your friend Search in the code Use static analysis tools
- 134. THANK YOU! Damien Seguy @exakat dseguy@exakat.io https://www.exakat.io/ https://joind.in/talk/615d8
- 135. THE END