The better way of code your tests is to have clean code.This way you will code clean tests.

1. Clean Code
in
Unit
Testing Mavi Jiménez

2. https://github.com/linkita/fee-calculator-tested

7. How is a unit
test

8. Asserts4
Mocks
Call
1
New2
3

9. public function testValidCalculateFeeRequestReturnFeeAsMoney()
{
$feeCalculatorMock = new FeeCalculatorMocks($this);
$tariffRepositoryMock = new TariffRepositoryMocks($this);
$calculateFeeRequestMock = new CalculateFeeRequestMocks($this);
$calculateFee = new CalculateFee(
$feeCalculatorMock->getMoney42(),
$tariffRepositoryMock->getTariffOne()
);
$money = $calculateFee->execute($calculateFeeRequestMock->complete());
$this->assertEquals($money->amount(), 42);
$this->assertEquals($money->currency(), Money::EUR);
}

10. public function testValidCalculateFeeRequestReturnFeeAsMoney()
{
$feeCalculatorMock = new FeeCalculatorMocks($this);
$tariffRepositoryMock = new TariffRepositoryMocks($this);
$calculateFeeRequestMock = new CalculateFeeRequestMocks($this);
$calculateFee = new CalculateFee(
$feeCalculatorMock->getMoney42(),
$tariffRepositoryMock->getTariffOne()
);
$money = $calculateFee->execute($calculateFeeRequestMock->complete());
$this->assertEquals($money->amount(), 42);
$this->assertEquals($money->currency(), Money::EUR);
}

11. public function testValidCalculateFeeRequestReturnFeeAsMoney()
{
$feeCalculatorMock = new FeeCalculatorMocks($this);
$tariffRepositoryMock = new TariffRepositoryMocks($this);
$calculateFeeRequestMock = new CalculateFeeRequestMocks($this);
$calculateFee = new CalculateFee(
$feeCalculatorMock->getMoney42(),
$tariffRepositoryMock->getTariffOne()
);
$money = $calculateFee->execute($calculateFeeRequestMock->complete());
$this->assertEquals($money->amount(), 42);
$this->assertEquals($money->currency(), Money::EUR);
}

12. public function testValidCalculateFeeRequestReturnFeeAsMoney()
{
$feeCalculatorMock = new FeeCalculatorMocks($this);
$tariffRepositoryMock = new TariffRepositoryMocks($this);
$calculateFeeRequestMock = new CalculateFeeRequestMocks($this);
$calculateFee = new CalculateFee(
$feeCalculatorMock->getMoney42(),
$tariffRepositoryMock->getTariffOne()
);
$money = $calculateFee->execute($calculateFeeRequestMock->complete());
$this->assertEquals($money->amount(), 42);
$this->assertEquals($money->currency(), Money::EUR);
}

13. assertTrue(true)

14. Let´s test, let´s mock

15. public function fourtyTwoEur()
{
$mock = $this->basicMock();
$mock
->expects($this->any())
->method('getAmount')
->willReturn(42);
$mock
->expects($this->any())
->method('getCurrency')
->willReturn(Money::EUR);
return $mock;
}

16. class Money
{
public const EUR = '€';
/** @var float */
private $amount;
/** @var string */
private $currency;
public function __construct(
float $amount,
string $currency
){
$this->amount = $amount;
$this->currency = $currency;
}
public function getAmount(): float
{
return $this->amount;
}
public function getCurrency(): string
{
return $this->currency;
}
}

21. Little garbage

22. /**
@var TestCase
*/
private $testCase;
public function __construct(TestCase $testCase)
{
$this->testCase = $testCase;
}
MockBuilder

23. class CalculateFeeTest extends TestCase
{
$calculateFeeRequestMock =
new CalculateFeeRequestMocks($this);
MockBuilder

24. /** @var ObjectProphecy */
private $prophet;
public function __construct(ObjectProphecy $prophet)
{
$this->prophet = $prophet;
}
Prophecy

25. $priceMock = new PriceMocks($this->prophesize(Price::class));
Prophecy

26. Which? How? Arg!
Testing!

27. Should be expressive
testMoneyFail

28. testOneWrongValueShouldThrowException
Should be expressive
testMoneyFail

29. :)
Happy path

30. Murphy's law
Corner cases

31. Less is more
Data providers

32. Make SOLID Tests

33. SOLID Single responsability
Open Close principle
Liskov substitution principle
Interface segregation principle
Dependency inversion

34. SOLID Single responsability
Open Close principle
Liskov substitution principle
Interface segregation principle
Dependency inversion
Make unit testing

35. SOLID Single responsability
Open Close principle
Liskov substitution principle
Interface segregation principle
Dependency inversion
New feature, new test class

36. SOLID Single responsability
Open Close principle
Liskov substitution principle
Interface segregation principle
Dependency inversion
All objects should be replaceable with
Mocks

37. SOLID Single responsability
Open Close principle
Liskov substitution principle
Interface segregation principle
Dependency inversion
Small interfaces, easy mocks

38. SOLID Single responsability
Open Close principle
Liskov substitution principle
Interface segregation principle
Dependency inversion
If you can't mock it, it's an antipattern!

39. Make
a
standard
documentation

40. testSemanticNameGivenReturnGoodKarma()
{
// ...
}
testClassFail()
{
// ...
}
/**
* @test
*/
shouldbeAtestWihoutAnnotation() {
// ...
}
bad
good

42. Clean Code
in
Unit
Testing

43. Clean Testing