Diese Präsentation wurde erfolgreich gemeldet.
Wir verwenden Ihre LinkedIn Profilangaben und Informationen zu Ihren Aktivitäten, um Anzeigen zu personalisieren und Ihnen relevantere Inhalte anzuzeigen. Sie können Ihre Anzeigeneinstellungen jederzeit ändern.
C++ Idioms by Example, lesson 1
                           I
             Introducing some very basic C++ idioms, rules, g...
Please criticise this program.

~/myprog/foo.hpp                                                     ~/myprog/foo.cpp
name...
What do you see in this code?

        Happiness?
or trouble?
I see trouble.

It looks like the code has been written by someone
with little experience in C++, or even worse, by
someon...
~/myprog/foo.hpp                    ~/myprog/foo.cpp
namespace bar {                     #include <iostream>
  class Foo {...
1. always compile with high warning level, and treat warnings as errors

~/myprog/foo.hpp                            ~/myp...
2. always use tools to support the building process

~/myprog/foo.hpp                                 ~/myprog/foo.cpp
nam...
3. do not _prefix member variables, use postfix_ if you must

~/myprog/foo.hpp                            ~/myprog/foo.cpp...
3. do not _prefix member variables, use postfix_ if you must

~/myprog/foo.hpp                            ~/myprog/foo.cpp...
4. public stuff should be declared first, then the private stuff

~/myprog/foo.hpp                               ~/myprog/...
4. public stuff should be declared first, then the private stuff

~/myprog/foo.hpp                               ~/myprog/...
5. single argument constructors should usually be explicit

~/myprog/foo.hpp                            ~/myprog/foo.cpp
n...
5. single argument constructors should usually be explicit

~/myprog/foo.hpp                            ~/myprog/foo.cpp
n...
6. initialize the state of the object properly

~/myprog/foo.hpp                                 ~/myprog/foo.cpp
namespac...
6. initialize the state of the object properly

~/myprog/foo.hpp                                 ~/myprog/foo.cpp
namespac...
7. use a consistent naming convention, camelCase or under_score

~/myprog/foo.hpp                         ~/myprog/foo.cpp...
7. use a consistent naming convention, camelCase or under_score

~/myprog/foo.hpp                         ~/myprog/foo.cpp...
8. do not prefix queries and modifiers with get/set

~/myprog/foo.hpp                             ~/myprog/foo.cpp
namespa...
8. do not prefix queries and modifiers with get/set

~/myprog/foo.hpp                             ~/myprog/foo.cpp
namespa...
9. do not import namespaces

~/myprog/foo.hpp                   ~/myprog/foo.cpp
namespace bar {                    #inclu...
9. do not import namespaces

~/myprog/foo.hpp                   ~/myprog/foo.cpp
namespace bar {                    #inclu...
10. query functions should be declared const

~/myprog/foo.hpp                           ~/myprog/foo.cpp
namespace bar { ...
10. query functions should be declared const

~/myprog/foo.hpp                           ~/myprog/foo.cpp
namespace bar { ...
11. non-const functions are modifiers

~/myprog/foo.hpp                        ~/myprog/foo.cpp
namespace bar {           ...
12. prefer free-standing functions

~/myprog/foo.hpp                       ~/myprog/foo.cpp
namespace bar {               ...
12. prefer free-standing functions

~/myprog/foo.hpp                       ~/myprog/foo.cpp
namespace bar {               ...
12. prefer free-standing functions

~/myprog/foo.hpp                       ~/myprog/foo.cpp
namespace bar {               ...
13. use anonymous namespaces for private free-standing functions

~/myprog/foo.hpp                         ~/myprog/foo.cp...
13. use anonymous namespaces for private free-standing functions

~/myprog/foo.hpp                         ~/myprog/foo.cp...
14. do not inline stuff in the class definition

~/myprog/foo.hpp                                  ~/myprog/foo.cpp
namesp...
14. do not inline stuff in the class definition

~/myprog/foo.hpp                                  ~/myprog/foo.cpp
namesp...
15. by default keep your stuff in the implementation file

~/myprog/foo.hpp                             ~/myprog/foo.cpp
n...
15. by default keep your stuff in the implementation file

~/myprog/foo.hpp                             ~/myprog/foo.cpp
n...
16. avoid member functions that both modifies and queries

~/myprog/foo.hpp                          ~/myprog/foo.cpp
name...
16. avoid member functions that both modifies and queries

~/myprog/foo.hpp                          ~/myprog/foo.cpp
name...
17. default arguments are depreciated, use delegation if you must

~/myprog/foo.hpp                           ~/myprog/foo...
17. default arguments are depreciated, use delegation if you must

~/myprog/foo.hpp                           ~/myprog/foo...
18. the K&R vs BS war is over, use an extra space around & and *

~/myprog/foo.hpp                          ~/myprog/foo.c...
18. the K&R vs BS war is over, use an extra space around & and *

~/myprog/foo.hpp                          ~/myprog/foo.c...
19. by not specifying const you say that something will change

~/myprog/foo.hpp                           ~/myprog/foo.cp...
19. by not specifying const you say that something will change

~/myprog/foo.hpp                              ~/myprog/foo...
20. reduce scope of variables

~/myprog/foo.hpp                              ~/myprog/foo.cpp
namespace bar {             ...
20. reduce scope of variables

~/myprog/foo.hpp                              ~/myprog/foo.cpp
namespace bar {             ...
21. for-loops in C++ are often not written like this

~/myprog/foo.hpp                               ~/myprog/foo.cpp
name...
21. for-loops in C++ are often not written like this

~/myprog/foo.hpp                               ~/myprog/foo.cpp
name...
22. in C++ you do not need to explicitly return from main

~/myprog/foo.hpp                              ~/myprog/foo.cpp
...
22. in C++ you do not need to explicitly return from main

~/myprog/foo.hpp                              ~/myprog/foo.cpp
...
22. in C++ you do not need to explicitly return from main

~/myprog/foo.hpp                              ~/myprog/foo.cpp
...
23. inject side-effects if you must have them

~/myprog/foo.hpp                                ~/myprog/foo.cpp
namespace ...
23. inject side-effects if you must have them

~/myprog/foo.hpp                                ~/myprog/foo.cpp
namespace ...
24. make sure headers compile by itself

~/myprog/foo.hpp                               ~/myprog/foo.cpp
namespace bar {  ...
24. make sure headers compile by itself

~/myprog/foo.hpp                               ~/myprog/foo.cpp
#include <iostrea...
25. include your own header file first, standard libraries last

~/myprog/foo.hpp                               ~/myprog/f...
25. include your own header file first, standard libraries last

~/myprog/foo.hpp                               ~/myprog/f...
26. prefer forward declarations in header files

~/myprog/foo.hpp                               ~/myprog/foo.cpp
#include ...
26. prefer forward declarations in header files

~/myprog/foo.hpp                               ~/myprog/foo.cpp
#include ...
27. don't need braces here

~/myprog/foo.hpp                               ~/myprog/foo.cpp
#include <iosfwd>             ...
27. don't need braces here

~/myprog/foo.hpp                               ~/myprog/foo.cpp
#include <iosfwd>             ...
28. avoid side-effects if you can, prefer free-standing functions

~/myprog/foo.hpp                               ~/myprog...
28. avoid side-effects if you can, prefer free-standing functions

~/myprog/foo.hpp                             ~/myprog/f...
29. do not open a namespace when implementing free-standing functions

~/myprog/foo.hpp                         ~/myprog/f...
29. do not open a namespace when implementing free-standing functions

~/myprog/foo.hpp                         ~/myprog/f...
30. operator overloading is sometimes a nice thing

~/myprog/foo.hpp                           ~/myprog/foo.cpp
#include <...
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
C++ idioms by example (Nov 2008)
Nächste SlideShare
Wird geladen in …5
×

C++ idioms by example (Nov 2008)

6.894 Aufrufe

Veröffentlicht am

Veröffentlicht in: Technologie, Business
  • DOWNLOAD FULL BOOKS, INTO AVAILABLE FORMAT ......................................................................................................................... ......................................................................................................................... 1.DOWNLOAD FULL. PDF EBOOK here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. EPUB Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. doc Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. PDF EBOOK here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. EPUB Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. doc Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... ......................................................................................................................... ......................................................................................................................... .............. Browse by Genre Available eBooks ......................................................................................................................... Art, Biography, Business, Chick Lit, Children's, Christian, Classics, Comics, Contemporary, Cookbooks, Crime, Ebooks, Fantasy, Fiction, Graphic Novels, Historical Fiction, History, Horror, Humor And Comedy, Manga, Memoir, Music, Mystery, Non Fiction, Paranormal, Philosophy, Poetry, Psychology, Religion, Romance, Science, Science Fiction, Self Help, Suspense, Spirituality, Sports, Thriller, Travel, Young Adult,
       Antworten 
    Sind Sie sicher, dass Sie …  Ja  Nein
    Ihre Nachricht erscheint hier
  • DOWNLOAD FULL. BOOKS INTO AVAILABLE FORMAT, ......................................................................................................................... ......................................................................................................................... 1.DOWNLOAD FULL. PDF EBOOK here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. EPUB Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. doc Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. PDF EBOOK here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. EPUB Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. doc Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... ......................................................................................................................... ......................................................................................................................... .............. Browse by Genre Available eBooks ......................................................................................................................... Art, Biography, Business, Chick Lit, Children's, Christian, Classics, Comics, Contemporary, Cookbooks, Crime, Ebooks, Fantasy, Fiction, Graphic Novels, Historical Fiction, History, Horror, Humor And Comedy, Manga, Memoir, Music, Mystery, Non Fiction, Paranormal, Philosophy, Poetry, Psychology, Religion, Romance, Science, Science Fiction, Self Help, Suspense, Spirituality, Sports, Thriller, Travel, Young Adult,
       Antworten 
    Sind Sie sicher, dass Sie …  Ja  Nein
    Ihre Nachricht erscheint hier
  • DOWNLOAD FULL. BOOKS INTO AVAILABLE FORMAT, ......................................................................................................................... ......................................................................................................................... 1.DOWNLOAD FULL. PDF EBOOK here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. EPUB Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. doc Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. PDF EBOOK here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. EPUB Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL. doc Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... ......................................................................................................................... ......................................................................................................................... .............. Browse by Genre Available eBooks ......................................................................................................................... Art, Biography, Business, Chick Lit, Children's, Christian, Classics, Comics, Contemporary, Cookbooks, Crime, Ebooks, Fantasy, Fiction, Graphic Novels, Historical Fiction, History, Horror, Humor And Comedy, Manga, Memoir, Music, Mystery, Non Fiction, Paranormal, Philosophy, Poetry, Psychology, Religion, Romance, Science, Science Fiction, Self Help, Suspense, Spirituality, Sports, Thriller, Travel, Young Adult,
       Antworten 
    Sind Sie sicher, dass Sie …  Ja  Nein
    Ihre Nachricht erscheint hier
  • DOWNLOAD FULL BOOKS INTO AVAILABLE FORMAT ......................................................................................................................... ......................................................................................................................... 1.DOWNLOAD FULL PDF EBOOK here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL EPUB Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL doc Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL PDF EBOOK here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL EPUB Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... 1.DOWNLOAD FULL doc Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... ......................................................................................................................... ......................................................................................................................... .............. Browse by Genre Available eBooks ......................................................................................................................... Art, Biography, Business, Chick Lit, Children's, Christian, Classics, Comics, Contemporary, Cookbooks, Crime, Ebooks, Fantasy, Fiction, Graphic Novels, Historical Fiction, History, Horror, Humor And Comedy, Manga, Memoir, Music, Mystery, Non Fiction, Paranormal, Philosophy, Poetry, Psychology, Religion, Romance, Science, Science Fiction, Self Help, Suspense, Spirituality, Sports, Thriller, Travel, Young Adult,
       Antworten 
    Sind Sie sicher, dass Sie …  Ja  Nein
    Ihre Nachricht erscheint hier
  • //DOWNLOAD THIS BOOKS INTO AVAILABLE FORMAT ......................................................................................................................... ......................................................................................................................... //DOWNLOAD PDF EBOOK here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... //DOWNLOAD EPUB Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... //DOWNLOAD doc Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... //DOWNLOAD PDF EBOOK here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... //DOWNLOAD EPUB Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... //DOWNLOAD doc Ebook here { https://tinyurl.com/y8nn3gmc } ......................................................................................................................... ......................................................................................................................... ......................................................................................................................... .............. Browse by Genre Available eBooks ......................................................................................................................... Art, Biography, Business, Chick Lit, Children's, Christian, Classics, Comics, Contemporary, Cookbooks, Crime, Ebooks, Fantasy, Fiction, Graphic Novels, Historical Fiction, History, Horror, Humor And Comedy, Manga, Memoir, Music, Mystery, Non Fiction, Paranormal, Philosophy, Poetry, Psychology, Religion, Romance, Science, Science Fiction, Self Help, Suspense, Spirituality, Sports, Thriller, Travel, Young Adult,
       Antworten 
    Sind Sie sicher, dass Sie …  Ja  Nein
    Ihre Nachricht erscheint hier

C++ idioms by example (Nov 2008)

  1. 1. C++ Idioms by Example, lesson 1 I Introducing some very basic C++ idioms, rules, guidelines and best practices h a Olve Maudal oma@pvv.org November 2008 Disclaimer: most of the items I will discuss here are indeed idioms and conventions of the C++ language, something that most experts will agree on. However some of the items are based on an ecolect – a programming style that is unique for a limited group of developers. There are also a few items based on my idiolect, which is a programming style that I believe in. And you may argue that one or two things I suggest here are just plain idiotic... My intention is not to tell you how to do C++ programming. I hope to use this presentation as a catalyst for discussion, therefor I have also included some controversial issues. Ignite your flamethrower. Choose your battles!
  2. 2. Please criticise this program. ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" int _value; int my_magic(int a, int b); using namespace std; public: Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) { int getValue() { _value = seed; return _value; } } void print(char* prefix); int Foo::my_magic(int a, int b) { }; return a + b - 3 + 8 - 5; } } int Foo::calc(int number) { int result = my_magic(_value, number); _value += result; ~/myprog/main.cpp return result; } #include "foo.hpp" void Foo::print(char *prefix) { int main() { cout << prefix << _value << "n"; bar::Foo foo(2); } char * prefix = "the answer="; } for(int i=0; i<4; i++) { foo.calc(i); Please criticise this program } foo.print(prefix); return 0; } Spend 5-10 minutes to read through the code. Imagine that this is a piece of code that you found in a larger codebase. Criticise everything you see, ... apart from the fact that it is a contrived, incorrect and stupid program that does not do anything useful, and is probably better written in Python as print “the $ cd ~/myprog answer=42” (and do not spend time on the implmentation of my_magic) $ g++ foo.cpp main.cpp && ./a.out the answer=43
  3. 3. What do you see in this code? Happiness?
  4. 4. or trouble?
  5. 5. I see trouble. It looks like the code has been written by someone with little experience in C++, or even worse, by someone who does not care... Large amount of this kind of code will make your codebase rot. But, once you start to believe - it is time to defeat the deteriorating agents
  6. 6. ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" int _value; int my_magic(int a, int b); using namespace std; public: Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) { int getValue() { _value = seed; return _value; } } void print(char* prefix); int Foo::my_magic(int a, int b) { }; return a + b - 3 + 8 - 5; } } int Foo::calc(int number) { int result = my_magic(_value, number); _value += result; ~/myprog/main.cpp return result; } #include "foo.hpp" void Foo::print(char *prefix) { int main() { cout << prefix << _value << "n"; bar::Foo foo(2); } char * prefix = "the answer="; } for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; } $ cd ~/myprog $ g++ foo.cpp main.cpp && ./a.out the answer=43
  7. 7. 1. always compile with high warning level, and treat warnings as errors ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" int _value; int my_magic(int a, int b); using namespace std; public: Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) { int getValue() { _value = seed; return _value; } } void print(char* prefix); int Foo::my_magic(int a, int b) { }; return a + b - 3 + 8 - 5; } } int Foo::calc(int number) { int result = my_magic(_value, number); _value += result; ~/myprog/main.cpp return result; } #include "foo.hpp" void Foo::print(char *prefix) { int main() { cout << prefix << _value << "n"; bar::Foo foo(2); } char * prefix = "the answer="; } for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; } $ cd ~/myprog $ g++ -Wall -Wextra -pedantic -Werror foo.cpp main.cpp && ./a.out the answer=43
  8. 8. 2. always use tools to support the building process ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" int _value; int my_magic(int a, int b); using namespace std; public: Foo(int seed); ~/myprog/Makefile int calc(int number = 7); namespace bar { Foo::Foo(int seed) { int getValue() { _value = seed; return _value; CPPFLAGS=-Wall -Wextra } -pedantic -Werror } LDFLAGS= void print(char* prefix); int Foo::my_magic(int a, int b) { }; return a + b - 3 + 8 - 5; } all: myprog } int Foo::calc(int number) { myprog: foo.o main.o int result = my_magic(_value, number); ~/myprog/main.cpp $(CXX) -o $@ $(LDFLAGS) $+ result; _value += return result; } #include "foo.hpp" clean: void Foo::print(char *prefix) { int main() { rm -f foo.o main.o myprog prefix << _value << cout << "n"; bar::Foo foo(2); } char * prefix = "the answer="; } for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; } $ cd ~/myprog $ make $ ./myprog the answer=43
  9. 9. 3. do not _prefix member variables, use postfix_ if you must ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" int _value; int my_magic(int a, int b); using namespace std; public: Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) { int getValue() { _value = seed; return _value; } } void print(char* prefix); int Foo::my_magic(int a, int b) { }; return a + b - 3 + 8 - 5; } } int Foo::calc(int number) { int result = my_magic(_value, number); _value += result; ~/myprog/main.cpp return result; } #include "foo.hpp" void Foo::print(char *prefix) { int main() { cout << prefix << _value << "n"; bar::Foo foo(2); } char * prefix = "the answer="; } for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  10. 10. 3. do not _prefix member variables, use postfix_ if you must ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" int value_; int my_magic(int a, int b); using namespace std; public: Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) { int getValue() { value_ = seed; return value_; } } void print(char* prefix); int Foo::my_magic(int a, int b) { }; return a + b - 3 + 8 - 5; } } int Foo::calc(int number) { int result = my_magic(value_, number); value_ += result; ~/myprog/main.cpp return result; } #include "foo.hpp" void Foo::print(char *prefix) { int main() { cout << prefix << value_ << "n"; bar::Foo foo(2); } char * prefix = "the answer="; } for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  11. 11. 4. public stuff should be declared first, then the private stuff ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" int value_; int my_magic(int a, int b); using namespace std; public: Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) { int getValue() { value_ = seed; return value_; } } void print(char* prefix); int Foo::my_magic(int a, int b) { }; return a + b - 3 + 8 - 5; } } int Foo::calc(int number) { int result = my_magic(value_, number); value_ += result; ~/myprog/main.cpp return result; } #include "foo.hpp" void Foo::print(char *prefix) { int main() { cout << prefix << value_ << "n"; bar::Foo foo(2); } char * prefix = "the answer="; } for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  12. 12. 4. public stuff should be declared first, then the private stuff ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: Foo(int seed); using namespace std; int calc(int number = 7); int getValue() { namespace bar { return value_; Foo::Foo(int seed) { } value_ = seed; void print(char* prefix); } private: int value_; int Foo::my_magic(int a, int b) { int my_magic(int a, int b); return a + b - 3 + 8 - 5; }; } } int Foo::calc(int number) { int result = my_magic(value_, number); value_ += result; ~/myprog/main.cpp return result; } #include "foo.hpp" void Foo::print(char *prefix) { int main() { cout << prefix << value_ << "n"; bar::Foo foo(2); } char * prefix = "the answer="; } for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  13. 13. 5. single argument constructors should usually be explicit ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: Foo(int seed); using namespace std; int calc(int number = 7); int getValue() { namespace bar { return value_; Foo::Foo(int seed) { } value_ = seed; void print(char* prefix); } private: int value_; int Foo::my_magic(int a, int b) { int my_magic(int a, int b); return a + b - 3 + 8 - 5; }; } } int Foo::calc(int number) { int result = my_magic(value_, number); value_ += result; ~/myprog/main.cpp return result; } #include "foo.hpp" void Foo::print(char *prefix) { int main() { cout << prefix << value_ << "n"; bar::Foo foo(2); } char * prefix = "the answer="; } for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  14. 14. 5. single argument constructors should usually be explicit ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); using namespace std; int calc(int number = 7); int getValue() { namespace bar { return value_; Foo::Foo(int seed) { } value_ = seed; void print(char* prefix); } private: int value_; int Foo::my_magic(int a, int b) { int my_magic(int a, int b); return a + b - 3 + 8 - 5; }; } } int Foo::calc(int number) { int result = my_magic(value_, number); value_ += result; ~/myprog/main.cpp return result; } #include "foo.hpp" void Foo::print(char *prefix) { int main() { cout << prefix << value_ << "n"; bar::Foo foo(2); } char * prefix = "the answer="; } for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  15. 15. 6. initialize the state of the object properly ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); using namespace std; int calc(int number = 7); int getValue() { namespace bar { return value_; Foo::Foo(int seed) { } value_ = seed; void print(char* prefix); } private: int value_; int Foo::my_magic(int a, int b) { int my_magic(int a, int b); return a + b - 3 + 8 - 5; }; } } int Foo::calc(int number) { int result = my_magic(value_, number); value_ += result; ~/myprog/main.cpp return result; } #include "foo.hpp" void Foo::print(char *prefix) { int main() { cout << prefix << value_ << "n"; bar::Foo foo(2); } char * prefix = "the answer="; } for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  16. 16. 6. initialize the state of the object properly ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); using namespace std; int calc(int number = 7); int getValue() { namespace bar { return value_; Foo::Foo(int seed) : value_(seed) { } } void print(char* prefix); private: int Foo::my_magic(int a, int b) { int value_; return a + b - 3 + 8 - 5; int my_magic(int a, int b); } }; } int Foo::calc(int number) { int result = my_magic(value_, number); value_ += result; return result; ~/myprog/main.cpp } #include "foo.hpp" void Foo::print(char *prefix) { cout << prefix << value_ << "n"; int main() { } bar::Foo foo(2); } char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  17. 17. 7. use a consistent naming convention, camelCase or under_score ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); using namespace std; int calc(int number = 7); int getValue() { namespace bar { return value_; Foo::Foo(int seed) : value_(seed) { } } void print(char* prefix); private: int Foo::my_magic(int a, int b) { int value_; return a + b - 3 + 8 - 5; int my_magic(int a, int b); } }; } int Foo::calc(int number) { int result = my_magic(value_, number); value_ += result; return result; ~/myprog/main.cpp } #include "foo.hpp" void Foo::print(char *prefix) { cout << prefix << value_ << "n"; int main() { } bar::Foo foo(2); } char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  18. 18. 7. use a consistent naming convention, camelCase or under_score ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); using namespace std; int calc(int number = 7); int getValue() { namespace bar { return value_; Foo::Foo(int seed) : value_(seed) { } } void print(char* prefix); private: int Foo::myMagic(int a, int b) { int value_; return a + b - 3 + 8 - 5; int myMagic(int a, int b); } }; } int Foo::calc(int number) { int result = myMagic(value_, number); value_ += result; return result; ~/myprog/main.cpp } #include "foo.hpp" void Foo::print(char *prefix) { cout << prefix << value_ << "n"; int main() { } bar::Foo foo(2); } char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  19. 19. 8. do not prefix queries and modifiers with get/set ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); using namespace std; int calc(int number = 7); int getValue() { namespace bar { return value_; Foo::Foo(int seed) : value_(seed) { } } void print(char* prefix); private: int Foo::myMagic(int a, int b) { int value_; return a + b - 3 + 8 - 5; int myMagic(int a, int b); } }; } int Foo::calc(int number) { int result = myMagic(value_, number); value_ += result; return result; ~/myprog/main.cpp } #include "foo.hpp" void Foo::print(char *prefix) { cout << prefix << value_ << "n"; int main() { } bar::Foo foo(2); } char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  20. 20. 8. do not prefix queries and modifiers with get/set ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); using namespace std; int calc(int number = 7); int value() { namespace bar { return value_; Foo::Foo(int seed) : value_(seed) { } } void print(char* prefix); private: int Foo::myMagic(int a, int b) { int value_; return a + b - 3 + 8 - 5; int myMagic(int a, int b); } }; } int Foo::calc(int number) { int result = myMagic(value_, number); value_ += result; return result; ~/myprog/main.cpp } #include "foo.hpp" void Foo::print(char *prefix) { cout << prefix << value_ << "n"; int main() { } bar::Foo foo(2); } char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  21. 21. 9. do not import namespaces ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); using namespace std; int calc(int number = 7); int value() { namespace bar { return value_; Foo::Foo(int seed) : value_(seed) { } } void print(char* prefix); private: int Foo::myMagic(int a, int b) { int value_; return a + b - 3 + 8 - 5; int myMagic(int a, int b); } }; } int Foo::calc(int number) { int result = myMagic(value_, number); value_ += result; return result; ~/myprog/main.cpp } #include "foo.hpp" void Foo::print(char *prefix) { cout << prefix << value_ << "n"; int main() { } bar::Foo foo(2); } char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  22. 22. 9. do not import namespaces ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) : value_(seed) { int value() { } return value_; } int Foo::myMagic(int a, int b) { void print(char* prefix); return a + b - 3 + 8 - 5; private: } int value_; int myMagic(int a, int b); int Foo::calc(int number) { }; int result = myMagic(value_, number); } value_ += result; return result; } ~/myprog/main.cpp void Foo::print(char *prefix) { std::cout << prefix << value_ << "n"; #include "foo.hpp" } } int main() { bar::Foo foo(2); char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  23. 23. 10. query functions should be declared const ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) : value_(seed) { int value() { } return value_; } int Foo::myMagic(int a, int b) { void print(char* prefix); return a + b - 3 + 8 - 5; private: } int value_; int myMagic(int a, int b); int Foo::calc(int number) { }; int result = myMagic(value_, number); } value_ += result; return result; } ~/myprog/main.cpp void Foo::print(char *prefix) { std::cout << prefix << value_ << "n"; #include "foo.hpp" } } int main() { bar::Foo foo(2); char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  24. 24. 10. query functions should be declared const ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) : value_(seed) { int value() const { } return value_; } int Foo::myMagic(int a, int b) { void print(char* prefix) const; return a + b - 3 + 8 - 5; private: } int value_; int myMagic(int a, int b); int Foo::calc(int number) { }; int result = myMagic(value_, number); } value_ += result; return result; } ~/myprog/main.cpp void Foo::print(char *prefix) const { std::cout << prefix << value_ << "n"; #include "foo.hpp" } } int main() { bar::Foo foo(2); char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  25. 25. 11. non-const functions are modifiers ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) : value_(seed) { int value() const { } ? return value_; } int Foo::myMagic(int a, int b) { void print(char* prefix) const; return a + b - 3 + 8 - 5; private: } int value_; int myMagic(int a, int b); int Foo::calc(int number) { }; int result = myMagic(value_, number); } value_ += result; return result; } ~/myprog/main.cpp void Foo::print(char *prefix) const { std::cout << prefix << value_ << "n"; #include "foo.hpp" } } int main() { bar::Foo foo(2); char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  26. 26. 12. prefer free-standing functions ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) : value_(seed) { int value() const { } return value_; } int Foo::myMagic(int a, int b) { void print(char* prefix) const; return a + b - 3 + 8 - 5; private: } int value_; int myMagic(int a, int b); int Foo::calc(int number) { }; int result = myMagic(value_, number); } value_ += result; return result; } ~/myprog/main.cpp void Foo::print(char *prefix) const { std::cout << prefix << value_ << "n"; #include "foo.hpp" } } int main() { bar::Foo foo(2); char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  27. 27. 12. prefer free-standing functions ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) : value_(seed) { int value() const { } return value_; } int Foo::myMagic(int a, int b) { void print(char* prefix) const; return a + b - 3 + 8 - 5; private: } int value_; int myMagic(int a, int b); int Foo::calc(int number) { }; int result = myMagic(value_, number); } value_ += result; return result; } ~/myprog/main.cpp void Foo::print(char *prefix) const { std::cout << prefix << value_ << "n"; #include "foo.hpp" } } int main() { bar::Foo foo(2); char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  28. 28. 12. prefer free-standing functions ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) : value_(seed) { int value() const { } return value_; } int myMagic(int a, int b) { void print(char* prefix) const; return a + b - 3 + 8 - 5; private: } int value_; }; int Foo::calc(int number) { } int result = myMagic(value_, number); value_ += result; return result; } ~/myprog/main.cpp void Foo::print(char *prefix) const { std::cout << prefix << value_ << "n"; #include "foo.hpp" } } int main() { bar::Foo foo(2); char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  29. 29. 13. use anonymous namespaces for private free-standing functions ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace bar { int calc(int number = 7); Foo::Foo(int seed) : value_(seed) { int value() const { } return value_; } int myMagic(int a, int b) { void print(char* prefix) const; return a + b - 3 + 8 - 5; private: } int value_; }; int Foo::calc(int number) { } int result = myMagic(value_, number); value_ += result; return result; } ~/myprog/main.cpp void Foo::print(char *prefix) const { std::cout << prefix << value_ << "n"; #include "foo.hpp" } } int main() { bar::Foo foo(2); char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  30. 30. 13. use anonymous namespaces for private free-standing functions ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { int calc(int number = 7); int myMagic(int a, int b) { int value() const { return a + b - 3 + 8 - 5; return value_; } } } void print(char* prefix) const; private: namespace bar { int value_; Foo::Foo(int seed) : value_(seed) { }; } } int Foo::calc(int number) { int result = myMagic(value_, number); value_ += result; return result; ~/myprog/main.cpp } #include "foo.hpp" void Foo::print(char *prefix) const { std::cout << prefix << value_ << "n"; int main() { } bar::Foo foo(2); } char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  31. 31. 14. do not inline stuff in the class definition ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { int calc(int number = 7); int myMagic(int a, int b) { int value() const { return a + b - 3 + 8 - 5; return value_; } } } void print(char* prefix) const; private: namespace bar { int value_; Foo::Foo(int seed) : value_(seed) { }; } } int Foo::calc(int number) { int result = myMagic(value_, number); value_ += result; return result; ~/myprog/main.cpp } #include "foo.hpp" void Foo::print(char *prefix) const { std::cout << prefix << value_ << "n"; int main() { } bar::Foo foo(2); } char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  32. 32. 14. do not inline stuff in the class definition ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { int calc(int number = 7); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(char* prefix) const; } private: } int value_; }; namespace bar { Foo::Foo(int seed) : value_(seed) { inline int Foo::value() const { } return value_; } int Foo::calc(int number) { } int result = myMagic(value_, number); value_ += result; return result; ~/myprog/main.cpp } #include "foo.hpp" void Foo::print(char *prefix) const { std::cout << prefix << value_ << "n"; int main() { } bar::Foo foo(2); } char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  33. 33. 15. by default keep your stuff in the implementation file ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { int calc(int number = 7); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(char* prefix) const; } private: } int value_; }; namespace bar { Foo::Foo(int seed) : value_(seed) { inline int Foo::value() const { } return value_; } int Foo::calc(int number) { } int result = myMagic(value_, number); value_ += result; return result; ~/myprog/main.cpp } #include "foo.hpp" void Foo::print(char *prefix) const { std::cout << prefix << value_ << "n"; int main() { } bar::Foo foo(2); } char * prefix = "the answer="; for(int i=0; i<4; i++) { foo.calc(i); } foo.print(prefix); return 0; }
  34. 34. 15. by default keep your stuff in the implementation file ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { int calc(int number = 7); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(char* prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } int Foo::calc(int number) { int result = myMagic(value_, number); value_ += result; return result; ~/myprog/main.cpp } #include "foo.hpp" int Foo::value() const { return value_; int main() { } bar::Foo foo(2); char * prefix = "the answer="; void Foo::print(char *prefix) const { for(int i=0; i<4; i++) { std::cout << prefix << value_ << "n"; foo.calc(i); } } } foo.print(prefix); return 0; }
  35. 35. 16. avoid member functions that both modifies and queries ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { int calc(int number = 7); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(char* prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } int Foo::calc(int number) { int result = myMagic(value_, number); value_ += result; return result; ~/myprog/main.cpp } #include "foo.hpp" int Foo::value() const { return value_; int main() { } bar::Foo foo(2); char * prefix = "the answer="; void Foo::print(char *prefix) const { for(int i=0; i<4; i++) { std::cout << prefix << value_ << "n"; foo.calc(i); } } } foo.print(prefix); return 0; }
  36. 36. 16. avoid member functions that both modifies and queries ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number = 7); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(char* prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(char *prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; char * prefix = "the answer="; } for(int i=0; i<4; i++) { } foo.calc(i); } foo.print(prefix); return 0; }
  37. 37. 17. default arguments are depreciated, use delegation if you must ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number = 7); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(char* prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(char *prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; char * prefix = "the answer="; } for(int i=0; i<4; i++) { } foo.calc(i); } foo.print(prefix); return 0; }
  38. 38. 17. default arguments are depreciated, use delegation if you must ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(char* prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(char *prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; char * prefix = "the answer="; } for(int i=0; i<4; i++) { } foo.calc(i); } foo.print(prefix); return 0; }
  39. 39. 18. the K&R vs BS war is over, use an extra space around & and * ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(char* prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(char *prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; char * prefix = "the answer="; } for(int i=0; i<4; i++) { } foo.calc(i); } foo.print(prefix); return 0; }
  40. 40. 18. the K&R vs BS war is over, use an extra space around & and * ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(char * prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(char * prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; char * prefix = "the answer="; } for(int i=0; i<4; i++) { } foo.calc(i); } foo.print(prefix); return 0; }
  41. 41. 19. by not specifying const you say that something will change ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(char * prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(char * prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; char * prefix = "the answer="; } for(int i=0; i<4; i++) { } foo.calc(i); } foo.print(prefix); return 0; }
  42. 42. 19. by not specifying const you say that something will change ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(const char * prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(const char * prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; const char * prefix = "the answer="; } for(int i=0; i<4; i++) { } foo.calc(i); } foo.print(prefix); return 0; }
  43. 43. 20. reduce scope of variables ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(const char * prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(const char * prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; const char * prefix = "the answer="; } for(int i=0; i<4; i++) { } foo.calc(i); } foo.print(prefix); return 0; }
  44. 44. 20. reduce scope of variables ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(const char * prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(const char * prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; for(int i=0; i<4; i++) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(prefix); return 0; }
  45. 45. 21. for-loops in C++ are often not written like this ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(const char * prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(const char * prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; for(int i=0; i<4; i++) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(prefix); return 0; }
  46. 46. 21. for-loops in C++ are often not written like this ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(const char * prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(const char * prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(prefix); return 0; }
  47. 47. 22. in C++ you do not need to explicitly return from main ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(const char * prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(const char * prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(prefix); return 0; }
  48. 48. 22. in C++ you do not need to explicitly return from main ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(const char * prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(const char * prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(prefix); return 0; }
  49. 49. 22. in C++ you do not need to explicitly return from main ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(const char * prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(const char * prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(prefix); }
  50. 50. 23. inject side-effects if you must have them ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <iostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(const char * prefix) const; } private: } int value_; }; namespace bar { } Foo::Foo(int seed) : value_(seed) { } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } int main() { void Foo::print(const char * prefix) const { bar::Foo foo(2); std::cout << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(prefix); }
  51. 51. 23. inject side-effects if you must have them ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <ostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(std::ostream & out, } const char * prefix) const; } private: int value_; namespace bar { }; Foo::Foo(int seed) : value_(seed) { } } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include <iostream> } #include "foo.hpp" void Foo::print(std::ostream & out, int main() { const char * prefix) const { bar::Foo foo(2); out << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(std::cout, prefix); }
  52. 52. 24. make sure headers compile by itself ~/myprog/foo.hpp ~/myprog/foo.cpp namespace bar { #include <ostream> class Foo { #include "foo.hpp" public: explicit Foo(int seed); namespace { void calc(int number); int myMagic(int a, int b) { int value() const; return a + b - 3 + 8 - 5; void print(std::ostream & out, } const char * prefix) const; } private: int value_; namespace bar { }; Foo::Foo(int seed) : value_(seed) { } } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include <iostream> } #include "foo.hpp" void Foo::print(std::ostream & out, int main() { const char * prefix) const { bar::Foo foo(2); out << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(std::cout, prefix); }
  53. 53. 24. make sure headers compile by itself ~/myprog/foo.hpp ~/myprog/foo.cpp #include <iostream> #include <ostream> #include "foo.hpp" namespace bar { class Foo { namespace { public: int myMagic(int a, int b) { explicit Foo(int seed); return a + b - 3 + 8 - 5; void calc(int number); } int value() const; } void print(std::ostream & out, const char * prefix) const; namespace bar { private: Foo::Foo(int seed) : value_(seed) { int value_; } }; } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include <iostream> } #include "foo.hpp" void Foo::print(std::ostream & out, int main() { const char * prefix) const { bar::Foo foo(2); out << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(std::cout, prefix); }
  54. 54. 25. include your own header file first, standard libraries last ~/myprog/foo.hpp ~/myprog/foo.cpp #include <iostream> #include <ostream> #include "foo.hpp" namespace bar { class Foo { namespace { public: int myMagic(int a, int b) { explicit Foo(int seed); return a + b - 3 + 8 - 5; void calc(int number); } int value() const; } void print(std::ostream & out, const char * prefix) const; namespace bar { private: Foo::Foo(int seed) : value_(seed) { int value_; } }; } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include <iostream> } #include "foo.hpp" void Foo::print(std::ostream & out, int main() { const char * prefix) const { bar::Foo foo(2); out << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(std::cout, prefix); }
  55. 55. 25. include your own header file first, standard libraries last ~/myprog/foo.hpp ~/myprog/foo.cpp #include <iostream> #include "foo.hpp" #include <ostream> namespace bar { class Foo { namespace { public: int myMagic(int a, int b) { explicit Foo(int seed); return a + b - 3 + 8 - 5; void calc(int number); } int value() const; } void print(std::ostream & out, const char * prefix) const; namespace bar { private: Foo::Foo(int seed) : value_(seed) { int value_; } }; } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } #include <iostream> void Foo::print(std::ostream & out, int main() { const char * prefix) const { bar::Foo foo(2); out << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(std::cout, prefix); }
  56. 56. 26. prefer forward declarations in header files ~/myprog/foo.hpp ~/myprog/foo.cpp #include <iostream> #include "foo.hpp" #include <ostream> namespace bar { class Foo { namespace { public: int myMagic(int a, int b) { explicit Foo(int seed); return a + b - 3 + 8 - 5; void calc(int number); } int value() const; } void print(std::ostream & out, const char * prefix) const; namespace bar { private: Foo::Foo(int seed) : value_(seed) { int value_; } }; } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } #include <iostream> void Foo::print(std::ostream & out, int main() { const char * prefix) const { bar::Foo foo(2); out << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(std::cout, prefix); }
  57. 57. 26. prefer forward declarations in header files ~/myprog/foo.hpp ~/myprog/foo.cpp #include <iosfwd> #include "foo.hpp" #include <ostream> namespace bar { class Foo { namespace { public: int myMagic(int a, int b) { explicit Foo(int seed); return a + b - 3 + 8 - 5; void calc(int number); } int value() const; } void print(std::ostream & out, const char * prefix) const; namespace bar { private: Foo::Foo(int seed) : value_(seed) { int value_; } }; } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } #include <iostream> void Foo::print(std::ostream & out, int main() { const char * prefix) const { bar::Foo foo(2); out << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(std::cout, prefix); }
  58. 58. 27. don't need braces here ~/myprog/foo.hpp ~/myprog/foo.cpp #include <iosfwd> #include "foo.hpp" #include <ostream> namespace bar { class Foo { namespace { public: int myMagic(int a, int b) { explicit Foo(int seed); return a + b - 3 + 8 - 5; void calc(int number); } int value() const; } void print(std::ostream & out, const char * prefix) const; namespace bar { private: Foo::Foo(int seed) : value_(seed) { int value_; } }; } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } #include <iostream> void Foo::print(std::ostream & out, int main() { const char * prefix) const { bar::Foo foo(2); out << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) { } foo.calc(i); } } const char * prefix = "the answer="; foo.print(std::cout, prefix); }
  59. 59. 27. don't need braces here ~/myprog/foo.hpp ~/myprog/foo.cpp #include <iosfwd> #include "foo.hpp" #include <ostream> namespace bar { class Foo { namespace { public: int myMagic(int a, int b) { explicit Foo(int seed); return a + b - 3 + 8 - 5; void calc(int number); } int value() const; } void print(std::ostream & out, const char * prefix) const; namespace bar { private: Foo::Foo(int seed) : value_(seed) { int value_; } }; } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } #include <iostream> void Foo::print(std::ostream & out, int main() { const char * prefix) const { bar::Foo foo(2); out << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) } foo.calc(i); } const char * prefix = "the answer="; foo.print(std::cout, prefix); }
  60. 60. 28. avoid side-effects if you can, prefer free-standing functions ~/myprog/foo.hpp ~/myprog/foo.cpp #include <iosfwd> #include "foo.hpp" #include <ostream> namespace bar { class Foo { namespace { public: int myMagic(int a, int b) { explicit Foo(int seed); return a + b - 3 + 8 - 5; void calc(int number); } int value() const; } void print(std::ostream & out, const char * prefix) const; namespace bar { private: Foo::Foo(int seed) : value_(seed) { int value_; } }; } void Foo::calc(int number) { value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } #include <iostream> void Foo::print(std::ostream & out, int main() { const char * prefix) const { bar::Foo foo(2); out << prefix << value_ << "n"; for (int i = 0; i != 4; ++i) } foo.calc(i); } const char * prefix = "the answer="; foo.print(std::cout, prefix); }
  61. 61. 28. avoid side-effects if you can, prefer free-standing functions ~/myprog/foo.hpp ~/myprog/foo.cpp #include <iosfwd> #include "foo.hpp" #include <ostream> namespace bar { class Foo { namespace { public: int myMagic(int a, int b) { explicit Foo(int seed); return a + b - 3 + 8 - 5; void calc(int number); } int value() const; } private: int value_; namespace bar { }; Foo::Foo(int seed) : value_(seed) { void print(std::ostream & out, } const char * prefix, const Foo & foo); void Foo::calc(int number) { } value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } #include <iostream> void print(std::ostream & out, int main() { const char * prefix, bar::Foo foo(2); const Foo & foo) { for (int i = 0; i != 4; ++i) out << prefix << foo.value() << "n"; foo.calc(i); } const char * prefix = "the answer="; } print(std::cout, prefix, foo); }
  62. 62. 29. do not open a namespace when implementing free-standing functions ~/myprog/foo.hpp ~/myprog/foo.cpp #include <iosfwd> #include "foo.hpp" #include <ostream> namespace bar { class Foo { namespace { public: int myMagic(int a, int b) { explicit Foo(int seed); return a + b - 3 + 8 - 5; void calc(int number); } int value() const; } private: int value_; namespace bar { }; Foo::Foo(int seed) : value_(seed) { void print(std::ostream & out, } const char * prefix, const Foo & foo); void Foo::calc(int number) { } value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } #include <iostream> void print(std::ostream & out, int main() { const char * prefix, bar::Foo foo(2); const Foo & foo) { for (int i = 0; i != 4; ++i) out << prefix << foo.value() << "n"; foo.calc(i); } const char * prefix = "the answer="; } print(std::cout, prefix, foo); }
  63. 63. 29. do not open a namespace when implementing free-standing functions ~/myprog/foo.hpp ~/myprog/foo.cpp #include <iosfwd> #include "foo.hpp" #include <ostream> namespace bar { class Foo { namespace { public: int myMagic(int a, int b) { explicit Foo(int seed); return a + b - 3 + 8 - 5; void calc(int number); } int value() const; } private: int value_; namespace bar { }; Foo::Foo(int seed) : value_(seed) { void print(std::ostream & out, } const char * prefix, const Foo & foo); void Foo::calc(int number) { } value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } #include <iostream> } int main() { void bar::print(std::ostream & out, bar::Foo foo(2); const char * prefix, for (int i = 0; i != 4; ++i) const bar::Foo & foo) { foo.calc(i); out << prefix << foo.value() << "n"; const char * prefix = "the answer="; } print(std::cout, prefix, foo); }
  64. 64. 30. operator overloading is sometimes a nice thing ~/myprog/foo.hpp ~/myprog/foo.cpp #include <iosfwd> #include "foo.hpp" #include <ostream> namespace bar { class Foo { namespace { public: int myMagic(int a, int b) { explicit Foo(int seed); return a + b - 3 + 8 - 5; void calc(int number); } int value() const; } private: int value_; namespace bar { }; Foo::Foo(int seed) : value_(seed) { void print(std::ostream & out, } const char * prefix, const Foo & foo); void Foo::calc(int number) { } value_ += myMagic(value_, number); } ~/myprog/main.cpp int Foo::value() const { return value_; #include "foo.hpp" } #include <iostream> } int main() { void bar::print(std::ostream & out, bar::Foo foo(2); const char * prefix, for (int i = 0; i != 4; ++i) const bar::Foo & foo) { foo.calc(i); out << prefix << foo.value() << "n"; const char * prefix = "the answer="; } print(std::cout, prefix, foo); }

×