ManageIQ Sprint 137 Review

1. SPRINT 137 REVIEW
- Sprint Ending May 25, 2020
May 27, 2020
Meeting Start: 11:00 am EST

2. 2
SPEAKERS
● Overview (Oleg Barenboim)
● UI (Harpreet Kataria)
● Providers (Adam Grare)
● Platform (Joe VLcek)
● API (Alberto Bellotti)
● Developer (Jason Frey)

3. 3

4. 4
* Note that some PRs are double labeled or have no labels. Beginning with Sprint 127, archived and forked repos are
excluded.

5. Repository Files
Lines of
Code Rating
Total
Issues
Complexity
Issues
Duplication
Issues
Bug Risk
Issues
Style
Issues Coverage
ManageIQ/manageiq 1721 82922 A 1069 473 296 40 260 NA
ManageIQ/manageiq-schema 862 18150 B 296 72 194 2 28 82.42
ManageIQ/manageiq-api 242 8351 B 210 104 97 7 2 94.04
ManageIQ/manageiq-ui-classic 2839 125783 C 4903 2383 975 194 569 NA
ManageIQ/manageiq-ui-service 408 13083 C 201 177 24 0 0 NA
ManageIQ/manageiq-automation_engine 204 8238 C 177 145 23 2 7 85.74
ManageIQ/manageiq-content 1549 9383 C 192 77 100 5 10 97.73
ManageIQ/manageiq-providers-amazon 124 4616 B 83 52 17 1 13 64.72
ManageIQ/manageiq-providers-ansible_tower 75 1802 A 24 15 7 1 1 83.36
ManageIQ/manageiq-providers-azure 101 3932 C 75 51 15 4 5 74.51
ManageIQ/manageiq-providers-azure_stack 76 1406 A 17 13 0 0 4 NA
ManageIQ/manageiq-providers-foreman 56 820 A 11 7 2 0 2 65.11
ManageIQ/manageiq-providers-google 84 1627 A 15 10 2 0 3 76.72
ManageIQ/manageiq-providers-kubernetes 81 3494 C 49 41 3 1 4 77.14
ManageIQ/manageiq-providers-lenovo 113 3671 A 52 10 38 0 4 48.5
ManageIQ/manageiq-providers-nuage 81 1581 B 20 8 11 0 1 91.73
ManageIQ/manageiq-providers-openshift 63 1260 A 8 4 2 1 1 38.76
ManageIQ/manageiq-providers-openstack 206 10601 B 231 136 79 3 13 73.06
ManageIQ/manageiq-providers-ovirt 126 6637 B 102 70 7 0 25 74.79
ManageIQ/manageiq-providers-redfish 68 1125 C 23 6 16 0 1 70.61
ManageIQ/manageiq-providers-scvmm 67 1683 B 25 14 4 0 7 70.57

6. 6
USER INTERFACE
(Harpreet Kataria)
PRs (UI, SUI, UI/REACT Components, API ): 42 Bugs: 10, Enhancements: 11, Dependencies: 9, Cleanup: 4, Technical
Debt/Refactoring: 3/1 others: 4
Bugs
● miq-select: default liveSearchFocus to false (#438)
● Move the openshift metrics hostname detection (#7043)
● Do not display second level menu if that has no visible items (#7040)
● Fix constantizing CloudVolume for disable? check (#7057)
● Fix csv download (#7059)
● Fix Chargeback Assignments for Datastores (#7066)

7. 7
USER INTERFACE
(Harpreet Kataria)
Enhancements
● Carbon - add carbon scss (#7068)
● Implemented FieldArray component and added it to the DDF mapper (#6999)
● Expose our DDF renderer and constants as an alias for other engines (#7005)
● React - override id, component; convert Breadcrumbs to functional (#7070)
● React - Converted VM Snapshot creation form to DDF (#7004)
● React - Convert trees to react (#6413)
● Removed listnav from non-explorer style summary screens and sub-screens (#6997)
● Split Chargeback explorer into 3 explorers (#7016)
● Chargeback Rates non explorer (#7039, #7016, #20156)
● Chargeback Assignments non explorer (#7049)

8. 8
USER INTERFACE
(Harpreet Kataria)
Removed listnav from non-explorer style summary screens and sub-screens (#6997)

9. 9
USER INTERFACE
(Harpreet Kataria)
Split Chargeback explorer into 3 explorers (#7016)
Before After

10. 10
USER INTERFACE
(Harpreet Kataria)
Chargeback Rates & Assignments Explorers

11. 11
USER INTERFACE
(Harpreet Kataria)
Chargeback Rates Features and startpage drop down entries before

12. 12
USER INTERFACE
(Harpreet Kataria)
Chargeback Rates & Assignments De-Explorization
Rates/Assignments
Before - Single link
● http://localhost:3000/chargeback_rate/explorer
● http://localhost:3000/chargeback_assignment/explorer
After Direct links to list, objects, forms
● http://localhost:3000/chargeback_rate/show_list
● http://localhost:3000/chargeback_rate/show/1
● http://localhost:3000/chargeback_rate/edit/1?pressed=chargeback_rates_edit
● http://localhost:3000/chargeback_rate/edit/62?pressed=chargeback_rates_new
● http://localhost:3000/chargeback_assignment/change_tab?uib-tab=Storage
● http://localhost:3000/chargeback_assignment/change_tab?uib-tab=Compute

13. 13
USER INTERFACE
(Harpreet Kataria)
Chargeback Rates & Assignments Demo
● Video Link on ManageIQ YouTube

14. 14
VMware
● Fix provisioning a VM to an NSX network (#580)
○ The VMwareWebService gem was missing the OpaqueNetworkBackingInfo data-type
● Handle non-administrative user without access to the LicenseManager (#579)
● Add an EmsEvent ems_ref for easy identification of VMware events (#576)
PROVIDERS
(Adam Grare)

15. 15
Openshift
● Improve metrics/alerts hostname detection (#172)
○ Move provider connection out of UI-classic and into provider
● Add metrics hostname detection for OCPv4 (#174)
○ The project and routes changed between v3 and v4
PROVIDERS
(Adam Grare)

16. 16

17. 17
OpenStack
● Add event catcher for the new Service Telemetry Framework (STF) service (#556)
○ Added to OSP16
○ Based on qpid_proton
○ Video demo: https://www.youtube.com/watch?v=ICBmlmHW2yQ
PROVIDERS
(Adam Grare)

18. 18
PLATFORM
(Joe VLcek)
69 PRs merged
Enhancements:
● Add ems_uid and ems_type to event payload manageiq/20179
● Add support for the oidc introspection endpoint manageiq-appliance_console/117 manageiq-appliance_consoleull/121
ManageIQ Pods (Kubernetes):
● Add OIDC config to allow for API access 492
● Remove ability to set the admin user password 500, 495
● Disable admin user API access when enableApplicationLocalLogin is false 505
● Add missing resource requests and limits 506, 504
● Enable setting storageclass 511
● Add oidcCaCertSecret parameter 514
Rails 5.2 Upgrade:
● Upgrade to rails 5.2.4.3 for some security fixes manageiq/20188
● Update schema to match manageiq rails version manageiq-schema/484

19. 19
● DDF Schema based validation for creates and updates of providers - (David H.) #830
POST /api/providers
{
“ddf” : true,
“name” : “Amazon Test”,
“type” : “ManageIQ::Providers::Amazon::CloudManager”,
“zone_id” : “6”,
“provider_region” : “us-east-1”,
“endpoints” : [ { “role” : “default” } ],
“bad_attr” : “bad-value”
}
{
"error": {
"kind": "bad_request",
"message": "Could not create the new provider - Invalid attributes specified in the request: ["bad_attr"]",
"klass": "Api::BadRequestError"
}
}
API
(Alberto Bellotti)

20. 20
● Added support for downloading report results - (Alberto B.) #839
Supports report results downloads as txt, csv and pdf (if available) via the result_type parameter
○ POST /api/results/:id - action request_download
POST /api/results/22
{
"action" : "request_download",
"result_type" : "csv"
}
{
"success": true,
"message": "Requesting a download of a csv report for Result id:22 name:VMware VM Summary",
"task_id": "46",
"task_href": "http://localhost:3000/api/tasks/46",
"task_results_href": "http://localhost:3000/api/tasks/46/task_results"
}
○ GET /api/tasks/:task_id/task_results
○ POST /api/results - bulk action request_download
Documentation available at: https://www.manageiq.org/docs/reference/latest/api/reference/reports
API
(Alberto Bellotti)

21. 21
● manageiq-style
○ Extracted from guides
○ .rubocop.yml and friends
DEVELOPER
(Jason Frey)

22. 22
Questions? Discussion?
Sprint 138 Review - June 10
Meeting Start: 10:30 am EST

23. THANK YOU
manageiq.org github.com/ManageIQ
twitter.com/ManageIQ gitter.im/ManageIQ/manageiq
facebook.com/manageiq talk.manageiq.org
youtube.com/user/ManageIQVideolinkedin.com/company/manageiq