Diese Präsentation wurde erfolgreich gemeldet.
Wir verwenden Ihre LinkedIn Profilangaben und Informationen zu Ihren Aktivitäten, um Anzeigen zu personalisieren und Ihnen relevantere Inhalte anzuzeigen. Sie können Ihre Anzeigeneinstellungen jederzeit ändern.

100 Duck-Sized Pull Requests

7.629 Aufrufe

Veröffentlicht am

A talk about working collaboratively in a team using Git version control. Key concept: breaking work apart into smaller pull-requests allows for better reviews, sharing responsibility, and safer deploys.

Veröffentlicht in: Technologie
  • Als Erste(r) kommentieren

  • Gehören Sie zu den Ersten, denen das gefällt!

100 Duck-Sized Pull Requests

  1. 1. 100 DUCK SIZED PULL-REQUESTS
  2. 2. I'M KURT. work: @Fullscript twitter: @kurtfunai email: me@kurtfunai.com
  3. 3. THE QUESTION: Would you rather have one ! sized PR, or 100 " sized PRs?
  4. 4. Inspiration
  5. 5. We ran into this all the time at Fullscript. 669 Files Changed 157 Commits 3,853 Lines of Code
  6. 6. This is ! Don't do this. " No one can safely review pull request and provide meaningful feedback.
  7. 7. Code Reviews are about shared responsibility. You should try and make reviewing your code easy for the other developer(s).
  8. 8. So what do we do instead? We break it apart into logical chunks that are easily reviewable.
  9. 9. WHAT DOES THIS LOOK LIKE?
  10. 10. Example Pull Request 2 Files Changed 1 Commit 11 Lines of Code
  11. 11. Small Pull Requests: > Quick reviews > Easier to test > Easier to revert & rollback changes > Less cognitive load on the reviewer > Constraints cause you to break the problem down
  12. 12. Questions?

×