Diese Präsentation wurde erfolgreich gemeldet.
Wir verwenden Ihre LinkedIn Profilangaben und Informationen zu Ihren Aktivitäten, um Anzeigen zu personalisieren und Ihnen relevantere Inhalte anzuzeigen. Sie können Ihre Anzeigeneinstellungen jederzeit ändern.

10 Tips for Effective Code Review

Code review is a vital tool for any team of a size greater than one! Atlassian relies on pull requests to ensure high quality code, effective knowledge transfer between teammates, and painless deployments. In this lightning talk we'll share ten tips in as many minutes on sizing reviews, picking reviewers, and effective review techniques to ensure your team is getting the most out of your code review process.

Products covered:
Bitbucket, JIRA Software, Fisheye / Crucible

  • Als Erste(r) kommentieren

10 Tips for Effective Code Review

  1. 1. TIM PETTERSEN • SENIOR DEVELOPER • ATLASSIAN • @KANNONBOY Ten tips for effective code review
  2. 2. 1. One issue, one pull request = 
  3. 3. 1. One issue, one pull request # what’s shipping? $ git branch --merged # what’s left to ship? $ git branch --no-merged
  4. 4. master IN REVIEW DONEIN PROGRESSOPEN Automatic Transitions
  5. 5. feature/JIRA-30 master IN REVIEW DONEIN PROGRESSOPEN Branch created! Automatic Transitions
  6. 6. feature/JIRA-30 master IN REVIEW DONEIN PROGRESSOPEN Pull Request Created! Automatic Transitions
  7. 7. feature/JIRA-30 master IN REVIEW DONEIN PROGRESSOPEN Pull Request Merged! Automatic Transitions
  8. 8. 2. Minimum TWO approvals before merge 3. Have 1.5x - 2.5x that number reviewers
  9. 9. Fewer reviewers find more defects 0 7.5 15 22.5 30 1 2 3 4 5 6 7 8 9 Defects/kLoC Number of Reviewers source: bit.ly/review-stats
  10. 10. More reviewers spend less time 0 7 14 21 28 1 2 3 4 5 6 Minutesspent/reviewer Number of Reviewers source: bit.ly/review-stats
  11. 11. 4. Use blame to pick reviewers
  12. 12. 4. Use blame to pick reviewers $ npm install -g git-guilt # find blame delta for current branch $ git guilt `git merge-base master HEAD` HEAD Alice Foo ++++++++++++++++++++++++(239) Bob Bar ++++++++ Eve Baz ------- Mira Ted ---------------- Bec Opal ------------------------(-159)
  13. 13. 4. Use blame to pick reviewers bit.ly/suggest-reviewers
  14. 14. 5. @mention specialists
  15. 15. 6. Stuck in review? Make Tuesday & Thursday inbox zero days
  16. 16. betterCode; 7. Move comments into code review comments // comments // in code
  17. 17. 8. Build a team policy, as a team… …and enforce it!
  18. 18. 9. Add screenshots for UI/UX changes (gifs / videos are even better)
  19. 19. 9. Add screenshots for UI/UX changes (gifs / videos are even better) Monosnap GIPHY ScreenFlow
  20. 20. Ask a programmer to review 10 lines of code, they'll find 10 issues. Ask them to do 500 lines and they'll say it looks good. @GIRAYOZIL “ ” 10. Keep it concise
  21. 21. 10. Keep it conciseSecondsperline Lines of Code 1 line per second 100 lines per second source: bit.ly/review-stats
  22. 22. Thank you! TIM PETTERSEN • SENIOR DEVELOPER • ATLASSIAN • @KANNONBOY

    Als Erste(r) kommentieren

    Loggen Sie sich ein, um Kommentare anzuzeigen.

  • sadhiesh

    May. 30, 2017
  • saber13812002

    Dec. 28, 2020

Code review is a vital tool for any team of a size greater than one! Atlassian relies on pull requests to ensure high quality code, effective knowledge transfer between teammates, and painless deployments. In this lightning talk we'll share ten tips in as many minutes on sizing reviews, picking reviewers, and effective review techniques to ensure your team is getting the most out of your code review process. Products covered: Bitbucket, JIRA Software, Fisheye / Crucible

Aufrufe

Aufrufe insgesamt

18.525

Auf Slideshare

0

Aus Einbettungen

0

Anzahl der Einbettungen

17.665

Befehle

Downloads

27

Geteilt

0

Kommentare

0

Likes

2

×