Code Stinkers Anonymous

Code Stinkers
Anonymous
Mark Cornick • Viget Labs
RubyNation • June 12, 2009

Friday, June 12, 2009

My name is Mark,
and I am a code stinker.


How I got here

10 years in sysadmin
before becoming a developer

Mostly self-taught;
almost never used my CS degree


A very Brief Introduction To
Edsger W. Dijkstra
who wiquot; be quoted a few times
in the next few slides


Edsger W.
Dijkstra
(1930-2002)
Notable for:
• Shortest path algorithm
• Reverse Polish notation
• Being a curmudgeon


How Do We Tell Truths
That Might Hurt?


My Back Pages
Or, “I was so much lamer then;
I’m less lame than that now”


BASIC


10 TEXT:HOME
20 GOSUB 100
30 END
100 ?“YES I JUST GOSUBBED FOR
NO REASON WHATSOEVER”
110 RETURN


“It is practicaquot;y impossible to teach
good programming style to students
that have had prior exposure to
BASIC: as potential programmers
they are mentaquot;y mutilated beyond
hope of regeneration.”

– Edsger W. Dijkstra


COBOL


IDENTIFICATION DIVISION.
PROGRAM-ID. COBOL-EXAMPLE.
PROCEDURE DIVISION.
MAIN.
IF YEAR <= 1991
DISPLAY 'COBOL! Argh!'.
STOP RUN.


“The use of COBOL cripples the
mind; its teaching should, therefore,
be regarded as a criminal oﬀense.”



FORTRAN


C HAD ENOUGH YET?
PROGRAM UGLY
WRITE(UNIT=*, FMT=*) 'FORTRAN!'
END


“[T]he infantile disorder”, by now
nearly 20 years old, is hopelessly
inadequate for whatever computer
application you have in mind
today: it is now too clumsy, too
risky, and too expensive to use.”



Perl


#/usr/bin/env perl
#
# (Insert some convoluted JAPH
# code/line noise here.)


Dijkstra doesn’t mention Perl,
but I don’t think he would have
liked it.


There’s More Than
One Way To Do It,
but many of them
are Wrong

What Sysadmins
Do All Day
and how it explains
the code they write


Get it done. Put the ﬁre out.
Then forget about it.

Short, quick scripts

#!/bin/sh
for year in 1996 1997 1998 1999 2000; do
rm -rf backups/${year}
done
echo quot;Sorry, all backups from the pretend Internet money
era have been purged.quot; | /usr/ucb/Mail -s quot;Your restore
requestquot; boss@example.com


Sysadmins aren’t agile


Sysadmins don’t do OO


Some Object-Oriented
Languages I Have Not Known


Python


Python seemed cool to me,
but I didn’t get it.


Java


I never learned Java.
Really.


The Predicament


Bad practice
as a non-developer
carries over


Dijkstra was right:
I never learned good style


Code
Smells


The Result


My code needs a lot of
refactoring


Maintenance is
diﬃcult


Fellow developers laugh and
kick sand in my face

The Goal


Write quality code
the ﬁrst time


Minimize the need for
refactoring


No more sand
kicked in my face!

On Refactoring
(a brief philosophical interlude)


Refactoring:
improving the non-functional
characteristics of the code
without screwing up the
functional parts.


Refactoring
An essential part
of a developer’s
healthy diet.


Refactoring is like sugar.
It’s sweet,
but too much is bad for you.


Time spent refactoring could
be spent actuaquot;y coding.


Time spent refactoring could
be spent factoring.


I do love refactoring, but
I make avoiding it a goal


Writing Better Code
Or, “It hurts when you do that? Don’t do that.”


Number one:


No, really.


99 out of 100
developers agree:
writing tests
leads to
writing better code

Test First

Testing Philosophies
And Frameworks

TDD, BDD, DDD,
TATFT, LMNOP.

Test::Unit, RSpec, minitest,
micronaut, bacon.

Fettucine, linguine,
martini, bikini.

I’m not going to tell you
which test framework to use*

* but I like Test::Unit with Shoulda and Factory Girl


Pick one
and stay with it.

Still don’t know
which one to use?
Find out what
your peers use, and
use that one.

At ﬁrst, writing tests
was completely foreign to me.

Until I decided to
appeal to my own ego.

I like being right.
(Don’t you?)


Testing is an
automated way of
proving I’m right.

(Or, at least, that my code is.)


Proving my code correct
motivates me
to keep writing
good code.


Be a good primate.
Use your tools.

Tools can help you
improve your code.


Tools cannot write good code
for you.


A Few Tools I Like
Or, “I got your take-home message right here”


RCov
gem install relevance-rcov
http://github.com/relevance/rcov


Checks code coverage
in your tests.


Why RCov Helps
• To reach full coverage,
you write more tests.
• As you write more tests,
you ﬁx more problems.
• As you ﬁx more problems,
you write better code!

Things To Look Out For
• RCov isn’t perfect.
• It will sometimes miss code that is
covered.

• It is easy to cheat.
• Just because it’s covered doesn’t mean the
code is awesome.


Reek
gem install reek
http://github.com/kevinrutherford/reek


Finds common smells
in your code.
quot;app/controllers/application_controller.rbquot; -- 3 warnings:
ApplicationController#username_for calls user.username multiple times (Duplication)
ApplicationController#username_for doesn't depend on instance state (Utility Function)
ApplicationController#username_for refers to user more than self (Feature Envy)

quot;app/controllers/groups_controller.rbquot; -- 5 warnings:
GroupsController#show calls params multiple times (Duplication)
GroupsController#show calls params[:page] multiple times (Duplication)
GroupsController#show calls params[:page].to_i multiple times (Duplication)
GroupsController#show has approx 6 statements (Long Method)
GroupsController#show/block/block is nested (Nested Iterators)

quot;app/controllers/sessions_controller.rbquot; -- 2 warnings:
SessionsController#create calls ﬂash multiple times (Duplication)
SessionsController#create has approx 8 statements (Long Method)

quot;app/controllers/user_feeds_controller.rbquot; -- 3 warnings:
UserFeedsController#create calls logger multiple times (Duplication)
UserFeedsController#create has approx 6 statements (Long Method)
UserFeedsController#create has the variable name 'e' (Uncommunicative Name)

quot;app/helpers/application_helper.rbquot; -- 14 warnings:
ApplicationHelper::feed_date_for doesn't depend on instance state (Utility Function)
ApplicationHelper::feed_date_for refers to date more than self (Feature Envy)
ApplicationHelper::feedstitch_group_for doesn't depend on instance state (Utility Function)
ApplicationHelper::feedstitch_group_for refers to user more than self (Feature Envy)
ApplicationHelper::link_to_group_feed has 4 parameters (Long Parameter List)
Friday, June 12, 2009 ApplicationHelper::name_for doesn't depend on instance state (Utility Function)

Why Reek Helps
• Reek ﬁnds common
anti-patterns.
• Anti-patterns are bad habits
that are worth breaking.
• Fewer bad habits ==
better code!


Things To Look Out For
• Reek also isn’t perfect.
• It false-positives often.
• It can only make suggestions.
• It doesn’t catch all possible code smells.


Let’s Talk About
How My Code Smells
Or, The Part Of The Presentation That Is Potentiaquot;y
Very Embarrassing To The Presenter


MVC
Learn it. Know it. Live it.


Obese Controllers

Do As I Say,
Not As I Did
Actual client project, 2007 (I am not making this up):

• One controller
• One method
• ~130 LOC
• Actual comment:
# OPTIMIZE: this is ugly


xxxxx XxxxxxXxxxxxxxxx < XxxxxxxxxxxXxxxxxxxxx # redacted for public publication
xxxxxx_xxxxxx :xxxxx_xxx_xxxx
xxxxxx_xxxxxx :xxxxxxx_xxx_xx_xxxxxxx, :xxxx => [:xxxx]â€šÃ„Â®
xxx xxxx
xxxxxx.xxxxxx(:xx_xxx_xxxxxxx)
xxxxxx[:xxxxxx] ||= Xxxxxxx::XXXXXX_XXXXXX
@xxxxxxx_xxxxxxx = xxxxxx.xxxxxx(:xxxxxxx_xxxxxxx)
xx xxxxxx[:xxxxxxxx_xxxx_xxxxxxx].xxx?
@xxxx_xxxxxxxxxx_xxx_xxxxxxx = xxxx
xxxx
@xxxx_xxxxxxxxxx_xxx_xxxxxxx = xxxxxx[:xxxxxxxx_xxxx_xxxxxxx].xxxxxxx?(quot;xxxx_xxxxxxxxxxquot;)
xx @xxxx_xxxxxxxxxx_xxx_xxxxxxx
xxxxxx[:xxxxxxxx_xxxx_xxxxxxx].xxxxxx(quot;xxxx_xxxxxxxxxxquot;)
xxxxxxxx_xxxxxx = Xxxx[*xxxxxxx[:xxxxxx]['xxxxxxxx_xxxx_xxxxx']]
xx xxxxxxxx_xxxxxx.xxxxxx > 9
xxxxxxxx_xxxxxx.xxxx{|x,x| x[1] <=> x[1]}[9..-1].xxxx xx |x|
xxxxxx[:xxxxxxxx_xxxx_xxxxxxx] << x[0]
xxx
xxx
xxx
xxxâ€šÃ„Â®
xx xxxxxx[:xxxx_xxxxxxx].xxx?
@xxxx_xxxxxx_xxx_xxxxxxx = xxxx
xxxx
@xxxx_xxxxxx_xxx_xxxxxxx = xxxxxx[:xxxx_xxxxxxx].xxxxxxx?(quot;xxxx_xxxxxxquot;)
xx @xxxx_xxxxxx_xxx_xxxxxxx
xxxxxx[:xxxx_xxxxxxx].xxxxxx(quot;xxxx_xxxxxxquot;)
xxxx_xxxxxx = Xxxx[*xxxxxxx[:xxxxxx]['xxxx_xxxxx']]
xx xxxx_xxxxxx.xxxxxx > 19
xxxx_xxxxxx.xxxx{|x,x| x[1] <=> x[1]}[19..-1].xxxx xx |x|
xxxxxx[:xxxx_xxxxxxx] << x[0]
xxx
xxx
xxx
xxxâ€šÃ„Â®
@xxxxxx = xxxxxxx_xxxxxx(xxxxxx[:xxxxxxxx])
xxxxxx @xxxxxx.xxx?
xxxxxx[:xxxxxxxx] = xxxxxxxxxx_xxxxxxx(@xxxxxx)
xxxxxxx_xxxxxx(:xxxxxx => xxxxxx[:xxxxxx], :xxxxxx_xxx => xxxxxx[:xxxxxx_xxx],
:xx_xxxxxxxx => xxxxxx[:xx_xxxxxxxx], :xxxxx => xxxx, :xxxxxx => xxxxxx[:xxxxxx].xx_x)
xxxx
xxxxx[:xxxxxx] = quot;Xxxxxxx xxxxxxxx, xxxxxx xxx xxxx xxxxxx xxxxx.quot;
@xxxxxxxx = [].xxxxxxxx(:xxxx => 1)
xxx
@xxxx_xxxxxxx = @xxxxxxxx[0,3]
@xxxxxxxxxx_xxxxxxx = (@xxxxxxxx[3,(Xxxxxxx.xxx_xxxx - 3)] || [])
@xxxxxxxx = @xxxxxxxx.xxxxxx
xx @xxxxxxxx.xxxxxxx_xx?(:xxxxxx) && !@xxxxxxxx.xxxxxx.xxx? && !@xxxxxxxx.xxxxxx.xxxxx?
@xxxxx_xxxxxx = Xxxx[*@xxxxxxxx.xxxxxx['xxxxx_xxxxx']]
@xxxx_xxxxxx = Xxxx[*@xxxxxxxx.xxxxxx['xxxx_xxxxx']]
@xxxxxxxx_xxxx_xxxxxx = Xxxx[*@xxxxxxxx.xxxxxx['xxxxxxxx_xxxx_xxxxx']]

xxxxxx_xxxxx_xxxxxx = Xxxx[*xxxxxxx[:xxxxxx]['xxxxx_xxxxx']]
xxxxxx_xxxx_xxxxxx = Xxxx[*xxxxxxx[:xxxxxx]['xxxx_xxxxx']]
xxxxxx_xxxxxxxx_xxxx_xxxxxx = Xxxx[*xxxxxxx[:xxxxxx]['xxxxxxxx_xxxx_xxxxx']]â€šÃ„Â®
xxxxxx_xxxxx_xxxxxx.xxxx xx |x,x|
@xxxxx_xxxxxx[x] = 0 xxxxxx @xxxxx_xxxxxx.xxx_xxx?(x)
xxx
xxxxxx_xxxx_xxxxxx.xxxx xx |x,x|
@xxxx_xxxxxx[x] = 0 xxxxxx @xxxx_xxxxxx.xxx_xxx?(x)
xxx
xxxxxx_xxxxxxxx_xxxx_xxxxxx.xxxx xx |x,x|
@xxxxxxxx_xxxx_xxxxxx[x] = 0 xxxxxx @xxxxxxxx_xxxx_xxxxxx.xxx_xxx?(x)
xxxâ€šÃ„Â®
@xxxxx_xxxxxx = @xxxxx_xxxxxx.xxxx
# OPTIMIZE: this is ugly
@xxxx_xxxxxx = @xxxx_xxxxxx.xxxx{|x,x| quot;#{xxxxxxx('%09x',xxxxxx_xxxx_xxxxxx[x[0]])} #{x[0]}quot; <=> quot;#{xxxxxxx('%09x',xxxxxx_xxxx_xxxxxx[x[0]])} #{x[0]}quot;}
@xxxxxxxx_xxxx_xxxxxx = @xxxxxxxx_xxxx_xxxxxx.xxxx{|x,x| quot;#{xxxxxxx('%09x',xxxxxx_xxxxxxxx_xxxx_xxxxxx[x[0]])} #{x[0]}quot; <=> quot;#{xxxxxxx('%09x',xxxxxx_xxxxxxxx_xxxx_xxxxxx[x[0]])} #{x[0]}quot;}â€šÃ„Â®
@xxxxxxxx_xxxxxx = @xxxxxxxx.xxxxxx

xxxxxxxx_xxx = []
xxxxxxxx_xxx = []
xxxxxx xxxxxxx[:xxxxxx]['xxxxxxxx_xxxxx_xxxxx'].xxx?
xxxxxxxx_xxx = Xxxx[*xxxxxxx[:xxxxxx]['xxxxxxxx_xxxxx_xxxxx']].xxxxxx_xx{|x,x| x.xxxxx?}.xxxxxxx{|x,x| x.xx_x}
xxx
xxxxxx xxxxxxx[:xxxxxx]['xxxxxxxx_xxxxx_xxxxx'].xxx?
xxxxxxxx_xxx = Xxxx[*xxxxxxx[:xxxxxx]['xxxxxxxx_xxxxx_xxxxx']].xxxxxx_xx{|x,x| x.xxxxx?}.xxxxxxx{|x,x| x.xx_x}
xxx
xxxxxxx_xxxxxxx = []
(xxxxxxxx_xxx+xxxxxxxx_xxx).xxxx xx |xxx|
xxxxx
xxxxxxx_xxxxxxx << Xxxxxx.xxxx(xxx)
xxxxxx XxxxxxXxxxxx::XxxxxxXxxXxxxx
@xxxxxxxx.xxxx{|x| x.xxxxx_xxx_xxxxx}
xxx
xxx
@xxxxxxx = @xxxxxxx_xxxx.xxxxxxx_xxxxxxx.xxxxxx{|xx| xxxxxxx_xxxxxxx.xxxxxxx?(xx.xxxxxx) && xx.xxxxxx.xxxxxxxxxx_xxxx=='Xxxx' && @xxxxxxx_xxxx.xxxxxxxx_xxx_xxxxxxx_xxxx.xxxxxxx?
(xx.xxxxxx.xxxxxxxxxx.xxxxxxxx_xxx)}
@xxx_xxxxxxx = @xxxxxxx_xxxx.xxxxxxx_xxxxxxx.xxxxxx{|xx| xxxxxxx_xxxxxxx.xxxxxxx?(xx.xxxxxx) && (xx.xxxxxx.xxxxxxxxxx_xxxx!='Xxxx' || !@xxxxxxx_xxxx.xxxxxxxx_xxx_xxxxxxx_xxxx.xxxxxxx?
(xx.xxxxxx.xxxxxxxxxx.xxxxxxxx_xxx))}
xxxx_xxxxxxx_xxx = @xxxxxxx.xxxxxxx{|xx| xx.xxxxxx.xx} & (xxxxxx[:xxxxxx_xxx] || []).xxxxxxx{|xx| xx.xx_x}
xxxx_xxx_xxxxxxx_xxx = @xxx_xxxxxxx.xxxxxxx{|xx| xx.xxxxxx.xx} & (xxxxxx[:xxxxxx_xxx] || []).xxxxxxx{|xx| xx.xx_x}
@xxxx_xxxxxxx_xxxxx = xxxx_xxxxxxx_xxx.xxxxxx
@xxxx_xxx_xxxxxxx_xxxxx = xxxx_xxx_xxxxxxx_xxx.xxxxxx
@xxxx_xxxxxx_xxx = xxxx_xxxxxxx_xxx + xxxx_xxx_xxxxxxx_xxx
@xxxxxxx.xxxx!{|x,x| (@xxxx_xxxxxx_xxx.xxxxxxx?(x.xxxxxx_xx) ? 1 : 0) <=> (@xxxx_xxxxxx_xxx.xxxxxxx?(x.xxxxxx_xx) ? 1 : 0)}
@xxx_xxxxxxx.xxxx!{|x,x| (@xxxx_xxxxxx_xxx.xxxxxxx?(x.xxxxxx_xx) ? 1 : 0) <=> (@xxxx_xxxxxx_xxx.xxxxxxx?(x.xxxxxx_xx) ? 1 : 0)}
@xxx_xxxxxxx = xxxxxxx_xxxxxxx - ([@xxxxxxx_xxxx.xxxxxx] + @xxxxxxx.xxxxxxx{|x| x.xxxxxx} + @xxx_xxxxxxx.xxxxxxx{|xx| xx.xxxxxx})
@xxx_xxxxxxx = @xxx_xxxxxxx.xxxxxx{|x| x.xxxxxxxxxx_xxxx == 'Xxxxxxx'}
@xxx_xxxxxxx.xxxx!{|x,x| (x.xxxxxxxxxx_xxxx=='Xxxxx' ? 1 : 0) <=> (x.xxxxxxxxxx_xxxx=='Xxxxx' ? 1 : 0)}
@xxx_xxxxxxx = @xxx_xxxxxxx[0,3]
xxxx
@xxxxx_xxxxxx = []
@xxxx_xxxxxx = []
@xxxxxxxx_xxxx_xxxxxx = []
@xxxxxxxx_xxxxxx = []
@xxxxxxx = []
@xxx_xxxxxxx = []
@xxxx_xxxxxx_xxx = []
@xxx_xxxxxxx = []
@xxxx_xxxxxxx_xxxxx = 0
@xxxx_xxx_xxxxxxx_xxxxx = 0
xxx
@xxxxxxx_xxxxxxxx_xxxxxxx = []
@xxxxxxx_xxxx_xxxxxxx = []
@xxxxxxx_xxxxx_xxxxxxx = []
xx xxxxxx[:xxxxxxxx_xxxx_xxxxxxx] && xxxxxx[:xxxxxxxx_xxxx_xxxxxxx].xxxx.xxxxxx != @xxxxxxxx_xxxx_xxxxxx.xxxxxx
@xxxxxxx_xxxxxxxx_xxxxxxx = xxxxxx[:xxxxxxxx_xxxx_xxxxxxx]
xxx
xx xxxxxx[:xxxx_xxxxxxx] && xxxxxx[:xxxx_xxxxxxx].xxxx.xxxxxx != @xxxx_xxxxxx.xxxxxx
@xxxxxxx_xxxx_xxxxxxx = xxxxxx[:xxxx_xxxxxxx]
xxx
xx xxxxxx[:xxxxx_xxxxxxx] && xxxxxx[:xxxxx_xxxxxxx].xxxx.xxxxxx != @xxxxx_xxxxxx.xxxxxx
@xxxxxxx_xxxxx_xxxxxxx = xxxxxx[:xxxxx_xxxxxxx]
xxx
xx @xxxxxxx_xxxxxxxx_xxxxxxx.xxxxx? && @xxxxxxx_xxxx_xxxxxxx.xxxxx? && @xxxxxxx_xxxxx_xxxxxxx.xxxxx?
xxxxxx [xxxxxx[:xxxxxxxx_xxxx_xxxxxxx],xxxxxx[:xxxx_xxxxxxx],xxxxxx[:xxxxx_xxxxxxx]] == [xxx,xxx,xxx]
@xxxxxxx_xxxxxxx = xxxx
xxx
xxx
xxx
xxxâ€šÃ„Â®


Why???
• Didn’t understand the domain.
• Not thinking in object-oriented
paradigm.
• Not thinking in MVC.
• Not pairing.
• Lousy tests.

What Really Goes
In A Controller?

• Code you need to respond to a
web request and render the result
• Not business logic
• Not complex operations on
objects


Controller Liposuction
• Everything in its right place.
• When you see yourself doing
business logic, move it to the model!
• When you see yourself deﬁning
view logic, move it to the view/
helper!


BIG
METH-
ODS

Finding Big Methods
• Too much stuﬀ happening; too
many concerns
• Too many LOC to comprehend
in a glance
• Logic inside logic

def response
if @response.nil?
@final_response = false
current = source
path = source.query.nil? ? source.path : quot;#{source.path}?#{source.query}quot;
until @final_response
Net::HTTP.start(current.host, current.port) do |http|
@response = http.get(path, 'User-Agent' => user_agent)
if @response.header['location']
current = URI.parse(@response.header['location'])
path = current.query.nil? ? current.path : quot;#{current.path}?#{current.query}quot;
else
@final_response = true
end
end
end
end
@response
end


Small Pieces,
Loosely Joined


Remember
UNIX?
Small tools doing one
job well ⇒ small
methods doing one
job well


Name Methods To
Communicate Intent
thing.expires_at <
Time.now thing.expired?

user.has_accepted_terms &&

!user.suspended
user.can_sign_in?


Don’t Do Too Much
In A Method
• When you see a method getting too
long, break it into smaquot;er methods.

• Hint: look for excessive indentation
and nested ifs.

• Hint: a method shouldn’t come close
to ﬁlling your editor window.


def self.user_agent
quot;Awesome App Ruby/#{RUBY_VERSION}quot;
end

def self.maximum_redirects
4
end

def initialize(url)
@url = url
end

def endpoint_for(uri)
endpoint = uri.path.sub(/^/?$/, '/')
endpoint += quot;?#{uri.query}quot; unless uri.query.blank?
endpoint
end

def fetch(url, redirects_remaining)
return if redirects_remaining == 0
begin
uri = URI.parse(url)
response = Net::HTTP.start(uri.host, uri.port) do |http|
http.get(endpoint_for(uri), {'User-Agent' => self.class.user_agent})
end
if response.is_a?(Net::HTTPRedirection)
response = fetch(response['location'], redirects_remaining - 1)
end
rescue URI::InvalidURIError
RAILS_DEFAULT_LOGGER.warn quot;Error parsing URL: '#{url}'quot;
end
response
end

def response
@response ||= fetch(@url, self.class.maximum_redirects)
end


Self-Review

• Don’t check it in if the tests fail.
• Use continuous integration to keep
yourself honest. (more on this later)

• Look over all your changes before you
commit.

• If you miss something and you’re using
Git, ﬁx it and git commit --amend


Peer Review
• Pair-program whenever you can. Pair
programming comes with built-in peer
review.

• Do regular code reviews with your peers.
During active development, weekly is
good.

• Listen to criticism. Don’t take it personaquot;y.
No one’s perfect.


Quality Takes
Time
By law, straight bourbon
must be aged in new, charred
oak barrels for at least two
years. Anything less yields
just whiskey, not bourbon.


Sysadmins are used
to ﬁghting ﬁres

Fireﬁghting is
not
the way to lasting code
quality.


Fireﬁghting results
in code that is
“just whiskey”
(and maybe not even that)


You may not have
two to four years,

but you stiquot;
shouldn’t rush

Working In A
Vacuum
Most of us don’t.
No one should.


Ethic of
Reciprocity

The
Golden
Rule

Code unto others
as you would have them
code unto you.


You hate ﬁxing
other people’s
bad code.


Don’t make other
people ﬁx yours!


One more tool:
Continuous Integration


Every time the code changes,
run the tests.


Know where a build broke
and who was responsible.


CI is a good idea
even if you work alone.


Some CI Options
• CruiseControl.rb,
cruisecontrolrb.thoughtworks.com

• Integrity, integrityapp.com
• RunCodeRun (hosted!),
runcoderun.com

• runcoderun.com/mcornick

Let’s Wrap This Up
Or, “I Hope You Know This Wiquot; Go Down On Your
Permanent Record”


Where we come from
inﬂuences where we go.


There’s still time to change
the road you’re on.

Test.
No matter how, just do it.


Use tools to help you,
not to do work for you.


Recognize anti-patterns.
Avoid them.


Play well with others.


Take pride in your work.
Appeal to your own ego.


Learn from mistakes.
Learn from refactoring.


Put it all together and
you will write better code.


The End.
This has been “Code Stinkers Anonymous”
by Mark Cornick. Thank you!
http://objectsinmirrors.com/
http://twitter.com/mcornick

Please rate this talk on SpeakerRate!
http://speakerrate.com/talks/1170

Code Stinkers Anonymous

Empfohlen

Empfohlen

Weitere ähnliche Inhalte

Andere mochten auch

Andere mochten auch (6)

Ähnlich wie Code Stinkers Anonymous

Ähnlich wie Code Stinkers Anonymous (20)

Kürzlich hochgeladen

Kürzlich hochgeladen (20)

Code Stinkers Anonymous