Effective Code Reviews
•
0 gefällt mir•1,076 views
Code reviews don’t have to be battlegrounds. Over the years, I discovered that some of my practices simply ended up working better than others. Here are a handful of tips for getting the most out of your code reviews. The full series of articles can be found here: http://www.hitthebits.com/p/code-reviews.html
Empfohlen
Weitere ähnliche Inhalte
Kürzlich hochgeladen
Kürzlich hochgeladen (20)
Empfohlen
Empfohlen (20)
Effective Code Reviews
- 1. Code Reviews
- 2. Code Review Nightmares • Content one day implementing a feature and now three "I spent Goes Here days and counting on the code review." - Nemanja Trifunovic (Source) • "...they dilute the engineer's sense of ownership of his work" - Fran Porretto (Source) • "Every code review I've been in has been a complete waste of valuable development time. It usually turned into "Why did you do it this way???? My way is better... " - Kevin Marois (typos corrected - Source)
- 3. Code Review Software • Content Goes Here Understand the context • Filter your thoughts • Archive and Summary
- 4. Ask Questions • Content Goes Here The author has already wrestled with coding decisions • Asking questions facilitates intelligent discussion • The trump card
- 5. Everyone Reviews Everything • Content passes! No free Goes Here • Tunnel vision is real • Opportunities to learn
- 6. More Information • Content Goes Here Code Review blog series: http://www.hitthebits.com/p/code-reviews.html Twitter: @djleeds My Blog: www.HitTheBits.com My Team’s Blog: www.DevelopWithPurpose.com
- 7. Thank you
Hinweis der Redaktion
- The forums on codeproject.com recently had a discussion thread about code reviews. Here are a handful of the bad experiences.
- Use code review software to conduct your reviews. It gives you a chance to understand more code context than a live walkthrough, it gives you an opportunity to filter your thoughts, and it provides a mechanism for archiving and summarizing your decisions so that you can review them even years later.
- Asking questions generally produces better results than simply telling someone what you think they did wrong. If you find a real defect, though, you can still play the trump card. Just use them sparingly.
- Senior level programmers don’t get a free pass – their code should be reviewed, too! Even the most experienced developers can get tunnel vision on a project. Reviewing a senior developer’s code also can provide excellent learning opportunities for everyone on the team.